gortiz commented on PR #11205: URL: https://github.com/apache/pinot/pull/11205#issuecomment-1683963385
I've decided to follow the approach suggested by @Jackie-Jiang on MailboxSendOperator. Now when always fail if the buffer is full. But that breaks the following tests, which verifies that EOS is sent even when the buffer size is null: ``` Error: MailboxSendOperatorTest.shouldSendDataBlock:159 expected EOS block to propagate next even if capacity is now 0. expected [TransferableBlock{blockType=eos, _numRows=0}] but found [TransferableBlock{blockType=error, _numRows=0}] ``` What do we want to do in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org