Jackie-Jiang commented on code in PR #11374:
URL: https://github.com/apache/pinot/pull/11374#discussion_r1298121563
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -219,6 +219,11 @@ Map<String, List<Operation>>
computeOperations(SegmentDirectory.Reader segmentRe
}
for (String column : existingAllColumns) {
+ if (_schema != null && !_schema.hasColumn(column)) {
Review Comment:
I think we should not apply the handler when `_schema == null`. Shall we do
a check in the beginning and directly return empty map if schema does not exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
