[GitHub] [pinot] Aravind-Suresh commented on a diff in pull request #11262: WIP: Vector data type in Pinot

2023-08-11 Thread via GitHub
Aravind-Suresh commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1291038629 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [pinot] pjpringle opened a new issue, #11322: Gapfill function fails if datatype in lastwithtime is not uppercased

2023-08-11 Thread via GitHub
pjpringle opened a new issue, #11322: URL: https://github.com/apache/pinot/issues/11322 NullPointerException at GapFillProcessor.java:109 for the following Fix is to uppercase DOUBLE within the lastwithvalue aggregate ``` SELECT GAPFILL(time_col,'1:MILLISECONDS:SIMPLE_DATE_F

[GitHub] [pinot] vmarchaud opened a new pull request, #11323: chore: UI fixes + docker build update

2023-08-11 Thread via GitHub
vmarchaud opened a new pull request, #11323: URL: https://github.com/apache/pinot/pull/11323 chore: UI improvement chore: few fixes fix: revert UI endpoint hardcoding chore: update scripts to build docker imageInstructions: 1. The PR has to be tagged with at least one

[GitHub] [pinot] vmarchaud closed pull request #11323: chore: UI fixes + docker build update

2023-08-11 Thread via GitHub
vmarchaud closed pull request #11323: chore: UI fixes + docker build update URL: https://github.com/apache/pinot/pull/11323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

2023-08-11 Thread via GitHub
gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1291096823 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java: ## @@ -203,84 +143,72 @@ public void shouldCallCancelOnOp

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

2023-08-11 Thread via GitHub
gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1291097043 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java: ## @@ -203,84 +143,72 @@ public void shouldCallCancelOnOp

[GitHub] [pinot] eaugene commented on pull request #11307: Adding query function override for distinct functions of multi valued column

2023-08-11 Thread via GitHub
eaugene commented on PR #11307: URL: https://github.com/apache/pinot/pull/11307#issuecomment-1674442292 #11292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

2023-08-11 Thread via GitHub
gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1291103612 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -173,30 +165,32 @@ public void cancel(long requestId) { @VisibleForTesti

[pinot] annotated tag release-1.0.0-rc0 deleted (was f8248d8f23)

2023-08-11 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc0 was deleted! *** tag was f8248d8f23 The revisions that were on t

[pinot] branch release-1.0.0-rc updated (f12930da8b -> 527eb4fddb)

2023-08-11 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard f12930da8b [maven-release-plugin] prepare for next development iteration discard 91497773ea [maven-rel

[GitHub] [pinot] dario-liberman closed pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

2023-08-11 Thread via GitHub
dario-liberman closed pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites) URL: https://github.com/apache/pinot/pull/11092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare release release-1.0.0-rc0

2023-08-11 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new d2feb81e6b [maven-releas

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare for next development iteration

2023-08-11 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new b6478ca91f [maven-releas

[pinot] annotated tag release-1.0.0-rc0 updated (d2feb81e6b -> 7383f40b17)

2023-08-11 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc0 was modified! *** from d2feb81e6b (commit) to 7383f40b17 (t

[GitHub] [pinot] dependabot[bot] opened a new pull request, #11324: Bump org.slf4j:slf4j-api from 1.7.25 to 2.0.7

2023-08-11 Thread via GitHub
dependabot[bot] opened a new pull request, #11324: URL: https://github.com/apache/pinot/pull/11324 Bumps [org.slf4j:slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.25 to 2.0.7. Commits https://github.com/qos-ch/slf4j/commit/d6a21ae68f8a996bc24526f82ec46907e6688bc0";>d6a21a

[pinot] branch dependabot/maven/org.slf4j-slf4j-api-2.0.7 created (now c2ad4f8a22)

2023-08-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.slf4j-slf4j-api-2.0.7 in repository https://gitbox.apache.org/repos/asf/pinot.git at c2ad4f8a22 Bump org.slf4j:slf4j-api from 1.7.25 to 2.0.7 No new revisions were

[GitHub] [pinot] dependabot[bot] opened a new pull request, #11325: Bump com.diffplug.spotless:spotless-maven-plugin from 2.28.0 to 2.38.0

2023-08-11 Thread via GitHub
dependabot[bot] opened a new pull request, #11325: URL: https://github.com/apache/pinot/pull/11325 Bumps [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.28.0 to 2.38.0. Changelog Sourced from https://github.com/diffplug/spotless/blob/main

[pinot] branch dependabot/maven/com.diffplug.spotless-spotless-maven-plugin-2.38.0 created (now bd0405a3ed)

2023-08-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.diffplug.spotless-spotless-maven-plugin-2.38.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at bd0405a3ed Bump com.diffplug.spotless:spotless-maven-

[GitHub] [pinot] matthewhelmke commented on issue #9990: Need to add documentation on how to specify avro schema inline for realtime ingestion config

2023-08-11 Thread via GitHub
matthewhelmke commented on issue #9990: URL: https://github.com/apache/pinot/issues/9990#issuecomment-1674649448 This has been fixed in https://github.com/pinot-contrib/pinot-docs/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pinot] dario-liberman commented on pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

2023-08-11 Thread via GitHub
dario-liberman commented on PR #11092: URL: https://github.com/apache/pinot/pull/11092#issuecomment-1674668813 @atris : I have refactored the PR as discussed 1. moving all inner classes into top level within a dedicated sub-package. 2. moving input validation as well as strategy cr

[GitHub] [pinot] FranMorilloAWS commented on issue #9869: Pinot stop consuming from Kinesis Data Stream

2023-08-11 Thread via GitHub
FranMorilloAWS commented on issue #9869: URL: https://github.com/apache/pinot/issues/9869#issuecomment-1674672985 Yes i modified the controller.vip.host to point to the loadbalancer of the controllers and it worked. However I am facing now an issue with that with the current Table Configura

[GitHub] [pinot] codecov-commenter commented on pull request #11325: Bump com.diffplug.spotless:spotless-maven-plugin from 2.28.0 to 2.38.0

2023-08-11 Thread via GitHub
codecov-commenter commented on PR #11325: URL: https://github.com/apache/pinot/pull/11325#issuecomment-1674686433 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11324: Bump org.slf4j:slf4j-api from 1.7.25 to 2.0.7

2023-08-11 Thread via GitHub
codecov-commenter commented on PR #11324: URL: https://github.com/apache/pinot/pull/11324#issuecomment-1674708955 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] FranMorilloAWS commented on issue #1051: Date function supports in PQL

2023-08-11 Thread via GitHub
FranMorilloAWS commented on issue #1051: URL: https://github.com/apache/pinot/issues/1051#issuecomment-1674739670 how would that query look like? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] chenboat commented on a diff in pull request #11273: Add Server API to get tenant pools

2023-08-11 Thread via GitHub
chenboat commented on code in PR #11273: URL: https://github.com/apache/pinot/pull/11273#discussion_r1291549364 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/InstanceResource.java: ## @@ -73,4 +75,20 @@ public List getInstanceTags() { } return Col

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11262: WIP: Vector data type in Pinot

2023-08-11 Thread via GitHub
jasperjiaguo commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1291646774 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11262: WIP: Vector data type in Pinot

2023-08-11 Thread via GitHub
jasperjiaguo commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1291646774 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] navina opened a new pull request, #11326: Cleanup HLC code

2023-08-11 Thread via GitHub
navina opened a new pull request, #11326: URL: https://github.com/apache/pinot/pull/11326 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6.

[GitHub] [pinot] MeihanLi commented on issue #11293: Reloading segments leads to high CPU usage

2023-08-11 Thread via GitHub
MeihanLi commented on issue #11293: URL: https://github.com/apache/pinot/issues/11293#issuecomment-1675205320 Thanks @Jackie-Jiang , We found also segment reloading thread can take ~1 core but it will trigger lots of G1 GC which can take ~4.5 cores. That explained why in production, we saw

[GitHub] [pinot] Jackie-Jiang merged pull request #11296: refactor argmin/max to exprmin/max and make it calcite compliant

2023-08-11 Thread via GitHub
Jackie-Jiang merged PR #11296: URL: https://github.com/apache/pinot/pull/11296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (527eb4fddb -> c6dd50aed7)

2023-08-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 527eb4fddb Include package-lock.json in generated sources (#11321) add c6dd50aed7 refactor argmin/max to exprmin/m

[GitHub] [pinot] Jackie-Jiang commented on issue #11313: ClassCastException while parsing the query/extracting table name

2023-08-11 Thread via GitHub
Jackie-Jiang commented on issue #11313: URL: https://github.com/apache/pinot/issues/11313#issuecomment-1675218027 Good catch. We should not compile SqlNode to PinotQuery because PinotQuery doesn't support all multi-stage engines. We should either directly extract table names from SqlNode or

[GitHub] [pinot] codecov-commenter commented on pull request #11326: Cleanup HLC code

2023-08-11 Thread via GitHub
codecov-commenter commented on PR #11326: URL: https://github.com/apache/pinot/pull/11326#issuecomment-1675233022 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] mcvsubbu commented on issue #11314: Error in Realtime Ingestion Marks Segment as Offline in Ideal State

2023-08-11 Thread via GitHub
mcvsubbu commented on issue #11314: URL: https://github.com/apache/pinot/issues/11314#issuecomment-1675248176 Marking it offline gave us the flow correctly in terms of dropping all resources in the server. @ankitsultana the way to recover is to run the realtime segment validation jo

[GitHub] [pinot] mcvsubbu commented on issue #11314: Error in Realtime Ingestion Marks Segment as Offline in Ideal State

2023-08-11 Thread via GitHub
mcvsubbu commented on issue #11314: URL: https://github.com/apache/pinot/issues/11314#issuecomment-1675248518 cc: @sajjad-moradi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[pinot] branch master updated: Tenant rebalance and status tracking APIs (#11128)

2023-08-11 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d6b1b4feba Tenant rebalance and status tracking AP

[GitHub] [pinot] snleee merged pull request #11128: Tenant rebalance and status tracking APIs

2023-08-11 Thread via GitHub
snleee merged PR #11128: URL: https://github.com/apache/pinot/pull/11128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] Jackie-Jiang merged pull request #11316: Remove the redundant OrderByExpressionContext::isDesc.

2023-08-11 Thread via GitHub
Jackie-Jiang merged PR #11316: URL: https://github.com/apache/pinot/pull/11316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (d6b1b4feba -> c229f97a1c)

2023-08-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from d6b1b4feba Tenant rebalance and status tracking APIs (#11128) add c229f97a1c Remove the redundant OrderByExpressio

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10927: [refactor] improve disk read for partial upsert handler

2023-08-11 Thread via GitHub
Jackie-Jiang commented on code in PR #10927: URL: https://github.com/apache/pinot/pull/10927#discussion_r1291838451 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -60,29 +63,59 @@ public PartialUpsertHandler(Schema sch

[GitHub] [pinot] Jackie-Jiang merged pull request #11320: Fix a bug in NULL ordering using ordinal.

2023-08-11 Thread via GitHub
Jackie-Jiang merged PR #11320: URL: https://github.com/apache/pinot/pull/11320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: Fix a bug in NULL ordering using ordinal. (#11320)

2023-08-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new dea2cacea9 Fix a bug in NULL ordering using ordin

[GitHub] [pinot] Jackie-Jiang merged pull request #11303: separate tags with commas as indicated in action doc

2023-08-11 Thread via GitHub
Jackie-Jiang merged PR #11303: URL: https://github.com/apache/pinot/pull/11303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: separate tags with commas as indicated in action doc (#11303)

2023-08-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 93a5a7eb46 separate tags with commas as indicated

[GitHub] [pinot] Jackie-Jiang commented on issue #11322: Gapfill function fails if datatype in lastwithtime is not uppercased

2023-08-11 Thread via GitHub
Jackie-Jiang commented on issue #11322: URL: https://github.com/apache/pinot/issues/11322#issuecomment-1675492234 Thanks for raising the issue. Do you want to also help contribute the fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pinot] chenboat merged pull request #11273: Add Server API to get tenant pools

2023-08-11 Thread via GitHub
chenboat merged PR #11273: URL: https://github.com/apache/pinot/pull/11273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated: Add Server API to get tenant pools (#11273)

2023-08-11 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5290b80c9b Add Server API to get tenant pools (

[GitHub] [pinot] xiangfu0 opened a new pull request, #11327: By default ignore virtual columns for select * queries in v2

2023-08-11 Thread via GitHub
xiangfu0 opened a new pull request, #11327: URL: https://github.com/apache/pinot/pull/11327 Override `expandStar` method to rewrite select * queries. See below examples for updated results: https://github.com/apache/pinot/assets/1202120/3bb88188-a977-4b39-b13a-c95db6192e7a";> htt

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11326: Cleanup HLC code

2023-08-11 Thread via GitHub
Jackie-Jiang commented on code in PR #11326: URL: https://github.com/apache/pinot/pull/11326#discussion_r1291890991 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConsumerFactory.java: ## @@ -51,6 +51,7 @@ void init(StreamConfig streamConfig) { * @param groupId

[GitHub] [pinot] Jackie-Jiang merged pull request #11309: Fix a NullPointerException bug in ScalarTransformFunctionWrapper.

2023-08-11 Thread via GitHub
Jackie-Jiang merged PR #11309: URL: https://github.com/apache/pinot/pull/11309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: Fix a NullPointerException bug in ScalarTransformFunctionWrapper. (#11309)

2023-08-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8a86c7b1f2 Fix a NullPointerException bug in Sca

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11277: Remove commons-httpclient 3.1 library dependency.

2023-08-11 Thread via GitHub
Jackie-Jiang commented on code in PR #11277: URL: https://github.com/apache/pinot/pull/11277#discussion_r1291904756 ## pinot-common/src/main/java/org/apache/pinot/common/http/MultiHttpRequestResponse.java: ## @@ -18,38 +18,26 @@ */ package org.apache.pinot.common.http; +imp

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11319: Consolidate per function/data type integration test

2023-08-11 Thread via GitHub
Jackie-Jiang commented on code in PR #11319: URL: https://github.com/apache/pinot/pull/11319#discussion_r1291911189 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/CustomDataQueryClusterIntegrationTest.java: ## @@ -0,0 +1,125 @@ +/** + * Licens

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11319: Consolidate per function/data type integration test

2023-08-11 Thread via GitHub
xiangfu0 commented on code in PR #11319: URL: https://github.com/apache/pinot/pull/11319#discussion_r1291912470 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/CustomDataQueryClusterIntegrationTest.java: ## @@ -0,0 +1,125 @@ +/** + * Licensed t

[GitHub] [pinot] codecov-commenter commented on pull request #11327: [multistage] Ignore virtual columns for select * queries in v2

2023-08-11 Thread via GitHub
codecov-commenter commented on PR #11327: URL: https://github.com/apache/pinot/pull/11327#issuecomment-1675577290 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11327?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] mcvsubbu commented on issue #11314: Error in Realtime Ingestion Marks Segment as Offline in Ideal State

2023-08-11 Thread via GitHub
mcvsubbu commented on issue #11314: URL: https://github.com/apache/pinot/issues/11314#issuecomment-1675585363 Correct, I realized after posting that you may have had a problem with one of the replicas. So, the thought was as follows: In general, if there are consumption issues

[GitHub] [pinot] abhioncbr opened a new issue, #11329: [Flaky Test]: PinotInstanceRestletResourceTest.instanceRetagHappyPathTest

2023-08-11 Thread via GitHub
abhioncbr opened a new issue, #11329: URL: https://github.com/apache/pinot/issues/11329 [PR Unit Test Fail](https://github.com/apache/pinot/actions/runs/5838111693/job/15834701243?pr=11277) ``` Error: Failures: Error: PinotInstanceRestletResourceTest.instanceRetagHappyPathTest

[GitHub] [pinot] xiangfu0 merged pull request #11327: [multistage] Ignore virtual columns for select * queries in v2

2023-08-11 Thread via GitHub
xiangfu0 merged PR #11327: URL: https://github.com/apache/pinot/pull/11327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated: By default ignore virtual columns for select * queries in v2 (#11327)

2023-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4325cf87ec By default ignore virtual columns for

[GitHub] [pinot] codecov-commenter commented on pull request #11328: Fix CASE WHEN expression operands ordering.

2023-08-11 Thread via GitHub
codecov-commenter commented on PR #11328: URL: https://github.com/apache/pinot/pull/11328#issuecomment-1675607945 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[pinot] branch master updated (4325cf87ec -> 51da2f5f67)

2023-08-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4325cf87ec By default ignore virtual columns for select * queries in v2 (#11327) add 51da2f5f67 Remove commons-ht

[GitHub] [pinot] Jackie-Jiang merged pull request #11277: Remove commons-httpclient 3.1 library dependency.

2023-08-11 Thread via GitHub
Jackie-Jiang merged PR #11277: URL: https://github.com/apache/pinot/pull/11277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] eaugene commented on a diff in pull request #11307: Adding query function override for distinct functions of multi valued column

2023-08-11 Thread via GitHub
eaugene commented on code in PR #11307: URL: https://github.com/apache/pinot/pull/11307#discussion_r1292069929 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -942,6 +950,30 @@ private static Set getSegmentPartitionedCol

[GitHub] [pinot] eaugene commented on pull request #11307: Adding query function override for distinct functions of multi valued column

2023-08-11 Thread via GitHub
eaugene commented on PR #11307: URL: https://github.com/apache/pinot/pull/11307#issuecomment-1675700218 > Other than distinct count, other aggregation function also have the MV variance. Let's handle all of them here since the logic is the same. I currently added for - DISTINC

[GitHub] [pinot] navina commented on a diff in pull request #11326: Cleanup HLC code

2023-08-11 Thread via GitHub
navina commented on code in PR #11326: URL: https://github.com/apache/pinot/pull/11326#discussion_r1292099419 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConsumerFactory.java: ## @@ -51,6 +51,7 @@ void init(StreamConfig streamConfig) { * @param groupId consu