dario-liberman commented on PR #11092: URL: https://github.com/apache/pinot/pull/11092#issuecomment-1674668813
@atris : I have refactored the PR as discussed 1. moving all inner classes into top level within a dedicated sub-package. 2. moving input validation as well as strategy creation and selection logic to a factory class. 3. stronger type-checking by making the main aggregation function parametric. 4. separating out the sorted strategy selection logic into a dedicated sub-class due to the added complexity; as unlike other strategies that can be selected at construction time, sorting can be decided only at aggregation time based on whether the segment being processed is actually sorted or not (eg. open segments may not be sorted). All previous tests for the different strategies remain untouched and continue to pass after the refactoring. Please re-review the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
