chenboat commented on code in PR #11273:
URL: https://github.com/apache/pinot/pull/11273#discussion_r1291549364
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/InstanceResource.java:
##########
@@ -73,4 +75,20 @@ public List<String> getInstanceTags() {
}
return Collections.emptyList();
}
+
+ @GET
+ @Path("pools")
+ @ApiOperation(value = "Tenant pools for current instance")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Success"), @ApiResponse(code = 500,
message = "Internal server error")
+ })
Review Comment:
1) can you add the javadoc to explain return result types? i.e.,The summary
in the PR looks good.
2) Can you add a Pinot doc reference to the definition of pool in Pinot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
