eaugene commented on code in PR #11307:
URL: https://github.com/apache/pinot/pull/11307#discussion_r1292069929
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -942,6 +950,30 @@ private static Set<String>
getSegmentPartitionedColumns(@Nullable TableConfig ta
return segmentPartitionedColumns;
}
+ /**
+ * Retrieve multivalued columns for a table.
+ * From the table Schema , we get the multi valued columns of dimension
fields.
+ *
+ * @param tableCache
+ * @param tableName
+ * @return multivalued columns of the table .
+ */
+ private static Set<String> getMultiValuedColumns(TableCache tableCache,
String tableName) {
Review Comment:
But here we just get the Schema once and use it to do override in the entire
query . If we want to do on-demand for each column when traversing the query ,
we need to loop the entire schema again to see if that's a multivalued column,
which I think would be much more ineffective. Other option I see is, holding
the Set<> MultiValued columns in Schema class during its creation , to prevent
looping the schema during each query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
