[pinot] branch release-1.0-rc updated: [maven-release-plugin] prepare release release-1.0-rc0

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0-rc by this push: new e39591750b [maven-release-pl

[pinot] annotated tag release-1.0-rc0 updated (e39591750b -> 6da0ff3571)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0-rc0 was modified! *** from e39591750b (commit) to 6da0ff3571 (tag)

[pinot] branch release-1.0-rc updated: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0-rc by this push: new 49fcd8c128 [maven-release-pl

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11262: WIP: Vector data type in Pinot

xiangfu0 commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1289738443 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11262: WIP: Vector data type in Pinot

xiangfu0 commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1289754840 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289769475 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/ExecutorServiceUtils.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11315: Enhance Minion task management

Jackie-Jiang opened a new pull request, #11315: URL: https://github.com/apache/pinot/pull/11315 Fix #11282 - Remove the unnecessary wait after scheduling a task - Enhance other task status APIs to first read workflow/job config to determine whether the task exists because when tas

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289819281 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/ExecutorServiceUtils.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] t0mpere commented on issue #11282: Minion Batch ingestion scheduling bottleneck

t0mpere commented on issue #11282: URL: https://github.com/apache/pinot/issues/11282#issuecomment-1672859111 Thanks this will help a lot 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289828568 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/ExecutorServiceUtils.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289833588 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java: ## @@ -188,4 +193,10 @@ private boolean isType(MetadataBlock.MetadataB

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289857744 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289862143 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289865538 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/TransformOperator.java: ## @@ -86,13 +86,14 @@ protected TransferableBlock getNextBlock() {

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289872541 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -44,6 +45,7 @@ public MultiStageOperator(OpChainExecutionCont

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289872541 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -44,6 +45,7 @@ public MultiStageOperator(OpChainExecutionCont

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289877958 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java: ## @@ -118,46 +118,52 @@ public String toExplainString() { @O

[GitHub] [pinot] codecov-commenter commented on pull request #11315: Enhance Minion task management

codecov-commenter commented on PR #11315: URL: https://github.com/apache/pinot/pull/11315#issuecomment-1672924075 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289886813 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -61,6 +61,9 @@ public GrpcSendingMailbox(String id, ChannelManager ch

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289954302 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ## @@ -31,151 +32,73 @@ import org.slf4j.LoggerFactory; -

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289956471 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -113,14 +113,11 @@ public MultiStageBrokerRequestHandler(

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289833588 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java: ## @@ -188,4 +193,10 @@ private boolean isType(MetadataBlock.MetadataB

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289961342 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SetOperator.java: ## @@ -112,15 +112,14 @@ protected void constructRightBlockSet() { pr

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289961773 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java: ## @@ -203,84 +143,72 @@ public void shouldCallCancelOnOp

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289962057 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperatorTest.java: ## @@ -139,21 +138,11 @@ public void shouldTimeoutOnExtraLo

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1290051875 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/SchedulerService.java: ## @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] [pinot] walterddr commented on a diff in pull request #11151: [multistage] Derive SUM return type to be PostgreSQL compatible

walterddr commented on code in PR #11151: URL: https://github.com/apache/pinot/pull/11151#discussion_r1290098860 ## pinot-query-planner/src/test/resources/queries/AggregatePlans.json: ## @@ -21,7 +21,7 @@ "sql": "EXPLAIN PLAN FOR SELECT AVG(a.col4) as avg, SUM(a.col4) a

[GitHub] [pinot] abhioncbr commented on issue #11300: Comma Join Failing

abhioncbr commented on issue #11300: URL: https://github.com/apache/pinot/issues/11300#issuecomment-1673212186 Fixed, closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pinot] abhioncbr closed issue #11300: Comma Join Failing

abhioncbr closed issue #11300: Comma Join Failing URL: https://github.com/apache/pinot/issues/11300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #11315: Enhance Minion task management

swaminathanmanish commented on code in PR #11315: URL: https://github.com/apache/pinot/pull/11315#discussion_r1290290403 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java: ## @@ -118,25 +117,19 @@ public synchroniz

[GitHub] [pinot] kirkrodrigues commented on a diff in pull request #11210: Add JsonLogTransformer to transform semi-structured log events to fit a table's schema without dropping fields.

kirkrodrigues commented on code in PR #11210: URL: https://github.com/apache/pinot/pull/11210#discussion_r1290341303 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/JsonLogTransformer.java: ## @@ -0,0 +1,534 @@ +/** + * Licensed to the Apach

[GitHub] [pinot] kirkrodrigues commented on a diff in pull request #11210: Add JsonLogTransformer to transform semi-structured log events to fit a table's schema without dropping fields.

kirkrodrigues commented on code in PR #11210: URL: https://github.com/apache/pinot/pull/11210#discussion_r1290341638 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/JsonLogTransformer.java: ## @@ -0,0 +1,534 @@ +/** + * Licensed to the Apach

[GitHub] [pinot] kirkrodrigues commented on a diff in pull request #11210: Add JsonLogTransformer to transform semi-structured log events to fit a table's schema without dropping fields.

kirkrodrigues commented on code in PR #11210: URL: https://github.com/apache/pinot/pull/11210#discussion_r1290342559 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/JsonLogTransformer.java: ## @@ -0,0 +1,534 @@ +/** + * Licensed to the Apach

[GitHub] [pinot] kirkrodrigues commented on a diff in pull request #11210: Add JsonLogTransformer to transform semi-structured log events to fit a table's schema without dropping fields.

kirkrodrigues commented on code in PR #11210: URL: https://github.com/apache/pinot/pull/11210#discussion_r1290343214 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/JsonLogTransformer.java: ## @@ -0,0 +1,534 @@ +/** + * Licensed to the Apach

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11262: WIP: Vector data type in Pinot

xiangfu0 commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1290417171 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] sajjad-moradi commented on issue #11276: Support for storage quota for realtime tables

sajjad-moradi commented on issue #11276: URL: https://github.com/apache/pinot/issues/11276#issuecomment-1673575018 > Support for quota for ingestion is best done through ingestion rate quota, which is already supported. Coupled with retention, this config can help determine how much data is

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11262: WIP: Vector data type in Pinot

xiangfu0 commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1290436300 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11262: WIP: Vector data type in Pinot

xiangfu0 commented on code in PR #11262: URL: https://github.com/apache/pinot/pull/11262#discussion_r1290436300 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/Vector.java: ## @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[pinot] annotated tag release-1.0.0-rc0 updated (2b5f2575e0 -> 638646e1dd)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc0 was modified! *** from 2b5f2575e0 (commit) to 638646e1dd (t

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new 598eeb740d [maven-releas

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #11315: Enhance Minion task management

zhtaoxiang commented on code in PR #11315: URL: https://github.com/apache/pinot/pull/11315#discussion_r1290464365 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java: ## @@ -326,27 +324,35 @@ public synchronized Set

[pinot] branch release-1.0.0-rc created (now 2b5f2575e0)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git at 2b5f2575e0 [maven-release-plugin] prepare release release-1.0.0-rc0 No new revisions were added by this

[pinot] branch masterPomBump created (now 873ecd4647)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch masterPomBump in repository https://gitbox.apache.org/repos/asf/pinot.git at 873ecd4647 [maven-release-plugin] prepare for next development iteration This branch includes the followi

[pinot] 01/01: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch masterPomBump in repository https://gitbox.apache.org/repos/asf/pinot.git commit 873ecd46478374bd32440fef19c50298e94c4d75 Author: Saurabh Dubey AuthorDate: Thu Aug 10 22:58:37 2023 +0530

[pinot] 01/01: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch masterPomBump in repository https://gitbox.apache.org/repos/asf/pinot.git commit a1ffd912f838b96af9a54bbf65fb1bd982b05505 Author: Saurabh Dubey AuthorDate: Thu Aug 10 22:58:37 2023 +0530

[pinot] branch masterPomBump updated (873ecd4647 -> a1ffd912f8)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch masterPomBump in repository https://gitbox.apache.org/repos/asf/pinot.git discard 873ecd4647 [maven-release-plugin] prepare for next development iteration new a1ffd912f8 [maven-releas

[pinot] branch master updated (ee4044c54b -> 0addf8138e)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ee4044c54b Added support for COMMA join (#11312) add 0addf8138e Add instrumentation for dcount merge. Release

[pinot] branch release-1.0.0-rc updated (598eeb740d -> 6fa426886e)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard 598eeb740d [maven-release-plugin] prepare for next development iteration discard 2b5f2575e0 [maven-rel

[pinot] annotated tag release-1.0.0-rc0 deleted (was 638646e1dd)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc0 was deleted! *** tag was 638646e1dd This change permanently disc

[pinot] branch release-1.0.0-rc updated (6fa426886e -> 91497773ea)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git from 6fa426886e Add projection operator utils to unify and allow plugability (#11291) add 91497773ea [m

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new f12930da8b [maven-releas

[pinot] annotated tag release-1.0-rc0 deleted (was 6da0ff3571)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0-rc0 was deleted! *** tag was 6da0ff3571 The revisions that were on this

[pinot] branch dependabot/maven/org.codehaus.mojo-versions-maven-plugin-2.16.0 deleted (was 049fc89079)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.codehaus.mojo-versions-maven-plugin-2.16.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 049fc89079 Bump org.codehaus.mojo:versions-maven-plugin from

[pinot] annotated tag release-1.0.0-rc0 updated (91497773ea -> f8248d8f23)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc0 was modified! *** from 91497773ea (commit) to f8248d8f23 (t

[pinot] branch master updated (0addf8138e -> 99a6a04587)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0addf8138e Add instrumentation for dcount merge. Release bitmaps for and/or doc id set to save memory. `performance` (

[GitHub] [pinot] Jackie-Jiang merged pull request #11304: Bump org.codehaus.mojo:versions-maven-plugin from 2.13.0 to 2.16.0

Jackie-Jiang merged PR #11304: URL: https://github.com/apache/pinot/pull/11304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang closed pull request #11305: Bump org.scala-lang:scala-library from 2.11.11 to 2.13.11

Jackie-Jiang closed pull request #11305: Bump org.scala-lang:scala-library from 2.11.11 to 2.13.11 URL: https://github.com/apache/pinot/pull/11305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pinot] branch dependabot/maven/org.javassist-javassist-3.29.2-GA deleted (was 5bfa4d7549)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.javassist-javassist-3.29.2-GA in repository https://gitbox.apache.org/repos/asf/pinot.git was 5bfa4d7549 Bump org.javassist:javassist from 3.19.0-GA to 3.29.2-GA T

[GitHub] [pinot] Jackie-Jiang closed pull request #11306: Bump org.javassist:javassist from 3.19.0-GA to 3.29.2-GA

Jackie-Jiang closed pull request #11306: Bump org.javassist:javassist from 3.19.0-GA to 3.29.2-GA URL: https://github.com/apache/pinot/pull/11306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] dependabot[bot] commented on pull request #11305: Bump org.scala-lang:scala-library from 2.11.11 to 2.13.11

dependabot[bot] commented on PR #11305: URL: https://github.com/apache/pinot/pull/11305#issuecomment-1673747594 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[pinot] branch dependabot/maven/org.scala-lang-scala-library-2.13.11 deleted (was c5242f31e9)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.scala-lang-scala-library-2.13.11 in repository https://gitbox.apache.org/repos/asf/pinot.git was c5242f31e9 Bump org.scala-lang:scala-library from 2.11.11 to 2.13.1

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11307: Adding query function override for distinct functions of multi valued column

Jackie-Jiang commented on code in PR #11307: URL: https://github.com/apache/pinot/pull/11307#discussion_r1290569887 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -1075,6 +1107,48 @@ private static void handleDistinctCo

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11307: Adding query function override for distinct functions of multi valued column

Jackie-Jiang commented on code in PR #11307: URL: https://github.com/apache/pinot/pull/11307#discussion_r1290573005 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -1075,6 +1107,48 @@ private static void handleDistinctCo

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11307: Adding query function override for distinct functions of multi valued column

Jackie-Jiang commented on code in PR #11307: URL: https://github.com/apache/pinot/pull/11307#discussion_r1290566949 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -378,6 +385,7 @@ private BrokerResponseNative handleReque

[GitHub] [pinot] Jackie-Jiang commented on issue #11278: Support configurable segment balancer strategy

Jackie-Jiang commented on issue #11278: URL: https://github.com/apache/pinot/issues/11278#issuecomment-1673770702 cc @chenboat who is also interested in this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11307: Adding query function override for distinct functions of multi valued column

Jackie-Jiang commented on code in PR #11307: URL: https://github.com/apache/pinot/pull/11307#discussion_r1290572394 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -1075,6 +1107,48 @@ private static void handleDistinctCo

[GitHub] [pinot] dependabot[bot] commented on pull request #11306: Bump org.javassist:javassist from 3.19.0-GA to 3.29.2-GA

dependabot[bot] commented on PR #11306: URL: https://github.com/apache/pinot/pull/11306#issuecomment-1673742593 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [pinot] Jackie-Jiang merged pull request #11308: Fix GREATEST and LEAST transform functions.

Jackie-Jiang merged PR #11308: URL: https://github.com/apache/pinot/pull/11308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11151: [multistage] Derive SUM return type to be PostgreSQL compatible

xiangfu0 commented on code in PR #11151: URL: https://github.com/apache/pinot/pull/11151#discussion_r1290579479 ## pinot-query-planner/src/test/resources/queries/AggregatePlans.json: ## @@ -21,7 +21,7 @@ "sql": "EXPLAIN PLAN FOR SELECT AVG(a.col4) as avg, SUM(a.col4) as

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11151: [multistage] Derive SUM return type to be PostgreSQL compatible

xiangfu0 commented on code in PR #11151: URL: https://github.com/apache/pinot/pull/11151#discussion_r1290579686 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeSystem.java: ## @@ -32,6 +32,9 @@ public class TypeSystem extends RelDataTypeSystemImpl { priva

[pinot] branch master updated (99a6a04587 -> bf721212bf)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 99a6a04587 Bump org.codehaus.mojo:versions-maven-plugin from 2.13.0 to 2.16.0 (#11304) add bf721212bf Fix GREATES

[GitHub] [pinot] xiangfu0 merged pull request #11151: [multistage] Derive SUM return type to be PostgreSQL compatible

xiangfu0 merged PR #11151: URL: https://github.com/apache/pinot/pull/11151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (bf721212bf -> 3bdc0e1c86)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from bf721212bf Fix GREATEST and LEAST transform functions. (#11308) add 3bdc0e1c86 [multistage] Derive SUM return typ

[GitHub] [pinot] Jackie-Jiang merged pull request #11243: Make task MaxAttemptsPerTask configurable

Jackie-Jiang merged PR #11243: URL: https://github.com/apache/pinot/pull/11243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (3bdc0e1c86 -> 3fd8c36de0)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3bdc0e1c86 [multistage] Derive SUM return type to be PostgreSQL compatible (#11151) add 3fd8c36de0 Make task MaxA

[GitHub] [pinot] shenyu0127 opened a new pull request, #11316: Remove the redundant OrderByExpressionContext::isDesc.

shenyu0127 opened a new pull request, #11316: URL: https://github.com/apache/pinot/pull/11316 This API is only used in precondition checks and tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] s0nskar closed pull request #11317: In ForwardIndexHandler, recollect column stats when converting raw to dict encoding

s0nskar closed pull request #11317: In ForwardIndexHandler, recollect column stats when converting raw to dict encoding URL: https://github.com/apache/pinot/pull/11317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pinot] s0nskar opened a new pull request, #11317: In ForwardIndexHandler, recollect column stats when converting raw to dict encoding

s0nskar opened a new pull request, #11317: URL: https://github.com/apache/pinot/pull/11317 Fixes #10508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [pinot] s0nskar opened a new pull request, #11318: In ForwardIndexHandler, recollect column stats when converting raw to…

s0nskar opened a new pull request, #11318: URL: https://github.com/apache/pinot/pull/11318 Fixes #10508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [pinot] codecov-commenter commented on pull request #11316: Remove the redundant OrderByExpressionContext::isDesc.

codecov-commenter commented on PR #11316: URL: https://github.com/apache/pinot/pull/11316#issuecomment-1673953729 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11318: In ForwardIndexHandler, recollect column stats when converting raw to…

codecov-commenter commented on PR #11318: URL: https://github.com/apache/pinot/pull/11318#issuecomment-1673971758 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11318?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10927: [refactor] improve disk read for partial upsert handler

Jackie-Jiang commented on code in PR #10927: URL: https://github.com/apache/pinot/pull/10927#discussion_r1290767908 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -60,29 +72,57 @@ public PartialUpsertHandler(Schema sch

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11315: Enhance Minion task management

Jackie-Jiang commented on code in PR #11315: URL: https://github.com/apache/pinot/pull/11315#discussion_r1290771548 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java: ## @@ -118,25 +117,19 @@ public synchronized Se

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11315: Enhance Minion task management

Jackie-Jiang commented on code in PR #11315: URL: https://github.com/apache/pinot/pull/11315#discussion_r1290771989 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java: ## @@ -326,27 +324,35 @@ public synchronized Se

[GitHub] [pinot] shenyu0127 commented on pull request #11316: Remove the redundant OrderByExpressionContext::isDesc.

shenyu0127 commented on PR #11316: URL: https://github.com/apache/pinot/pull/11316#issuecomment-1674053396 > I feel we can just keep it even though it is not used frequently. Basically it is `!isAsc()` I prefer to remove `isDesc` because - It is redundant - We have`isNullsLast`

[GitHub] [pinot] deemoliu commented on a diff in pull request #10927: [refactor] improve disk read for partial upsert handler

deemoliu commented on code in PR #10927: URL: https://github.com/apache/pinot/pull/10927#discussion_r1290791520 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java: ## @@ -37,6 +43,7 @@ public class PartialUpsertHandler { priva

[GitHub] [pinot] xiangfu0 opened a new pull request, #11319: Consolidate per function/data type integration test

xiangfu0 opened a new pull request, #11319: URL: https://github.com/apache/pinot/pull/11319 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [pinot] codecov-commenter commented on pull request #11319: Consolidate per function/data type integration test

codecov-commenter commented on PR #11319: URL: https://github.com/apache/pinot/pull/11319#issuecomment-1674110334 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] shenyu0127 opened a new pull request, #11320: Fix a bug in NULL ordering using ordinal.

shenyu0127 opened a new pull request, #11320: URL: https://github.com/apache/pinot/pull/11320 After https://github.com/apache/pinot/pull/10805, there can be either one (ASC/DESC) or two (NULLS FIRST/NULLS LAST + ASC/DESC) levels of functions wrapping the ORDER BY expression. The `OrdinalsUp

[GitHub] [pinot] codecov-commenter commented on pull request #11320: Fix a bug in NULL ordering using ordinal.

codecov-commenter commented on PR #11320: URL: https://github.com/apache/pinot/pull/11320#issuecomment-1674146697 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] cbalci commented on a diff in pull request #11098: Introduce FrequentStringsSketch and FrequentLongsSketch aggregation functions

cbalci commented on code in PR #11098: URL: https://github.com/apache/pinot/pull/11098#discussion_r1290848973 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FrequentLongsSketchAggregationFunction.java: ## @@ -0,0 +1,251 @@ +/** + * Licensed to the A

[GitHub] [pinot] cbalci commented on a diff in pull request #11098: Introduce FrequentStringsSketch and FrequentLongsSketch aggregation functions

cbalci commented on code in PR #11098: URL: https://github.com/apache/pinot/pull/11098#discussion_r1290848886 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FrequentLongsSketchAggregationFunction.java: ## @@ -0,0 +1,251 @@ +/** + * Licensed to the A

[GitHub] [pinot] cbalci commented on a diff in pull request #11098: Introduce FrequentStringsSketch and FrequentLongsSketch aggregation functions

cbalci commented on code in PR #11098: URL: https://github.com/apache/pinot/pull/11098#discussion_r1290848886 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FrequentLongsSketchAggregationFunction.java: ## @@ -0,0 +1,251 @@ +/** + * Licensed to the A

[GitHub] [pinot] cbalci commented on pull request #11098: Introduce FrequentStringsSketch and FrequentLongsSketch aggregation functions

cbalci commented on PR #11098: URL: https://github.com/apache/pinot/pull/11098#issuecomment-1674156926 Thanks for the review @chenboat. Addressed the comments, please take another look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pinot] saurabhd336 opened a new pull request, #11321: Include package-lock.json in generated sources

saurabhd336 opened a new pull request, #11321: URL: https://github.com/apache/pinot/pull/11321 Include package-lock.json in generated sources -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pinot] codecov-commenter commented on pull request #11321: Include package-lock.json in generated sources

codecov-commenter commented on PR #11321: URL: https://github.com/apache/pinot/pull/11321#issuecomment-1674234428 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11321?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] snleee merged pull request #11321: Include package-lock.json in generated sources

snleee merged PR #11321: URL: https://github.com/apache/pinot/pull/11321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[pinot] branch master updated: Include package-lock.json in generated sources (#11321)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 527eb4fddb Include package-lock.json in generated