gortiz commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1289961342
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SetOperator.java:
##########
@@ -112,15 +112,14 @@ protected void constructRightBlockSet() {
protected TransferableBlock constructResultBlockSet(TransferableBlock
leftBlock) {
List<Object[]> rows = new ArrayList<>();
+ // TODO: Other operators keep the first erroneous block, while this keep
the last.
+ // We should decide what is what we want to do and be consistent with
that.
Review Comment:
I think once we read an error from an operator, we don't read that operator
again. But in case we do, what should we return? The first error or a new one?
Right now some operators keep the first error emitted and always return the
same error afterwards, but others create a new error each time they are being
called.
My TODO is to try to homogenize that to either always return the first error
or always create a new one. Alternative, we can define that we cannot call
`getNextBlock()` (or read from mailboxes) once the first error is emitted. In
that case we should throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
