shenyu0127 commented on PR #11316: URL: https://github.com/apache/pinot/pull/11316#issuecomment-1674053396
> I feel we can just keep it even though it is not used frequently. Basically it is `!isAsc()` I prefer to remove `isDesc` because - It is redundant - We have`isNullsLast` and we don't have `isNullsFirst`, removing `isDesc` makes the methods consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
