tarun11Mavani commented on code in PR #15756:
URL: https://github.com/apache/pinot/pull/15756#discussion_r2085980360
##
pinot-core/src/test/java/org/apache/pinot/core/operator/docidsets/OrDocIdSetTest.java:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation
ankitsultana commented on code in PR #15756:
URL: https://github.com/apache/pinot/pull/15756#discussion_r2085183246
##
pinot-core/src/test/java/org/apache/pinot/core/operator/docidsets/OrDocIdSetTest.java:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation
chenboat merged PR #15756:
URL: https://github.com/apache/pinot/pull/15756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
tarun11Mavani commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2870034323
fyi: the test failure is due to unrelated intermittent test failure in
minions tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rohityadav1993 commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2869415023
@Jackie-Jiang , @chenboat can this be merged now, we see this to be a more
urgent fix due to incorrect data.
Going forward it will be good to have UT coverage around critical
tarun11Mavani commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2869188043
> Which AND among the two are you referring to?
>
> > **What type of queries are impacted?** When we have a query of type `AND
(condition1 OR condition2) AND REGEXP_LIKE`, the
tarun11Mavani commented on code in PR #15756:
URL: https://github.com/apache/pinot/pull/15756#discussion_r2083304445
##
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##
@@ -77,6 +77,7 @@ public BlockDocIdIterator iterator() {
sortedD
tarun11Mavani commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2869182301
> Wow, how did I miss this.. By reading the code, this would skip docs
matched with bitmap and produce wrong result if there are multiple filters on
sorted column and some filters o
chenboat commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2868204392
@Jackie-Jiang I added a test to confirm the behavior
https://github.com/apache/pinot/pull/15763
cc @tarun11Mavani @rohityadav1993
--
This is an automated message from the Apach
chenboat commented on code in PR #15756:
URL: https://github.com/apache/pinot/pull/15756#discussion_r2082243637
##
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##
@@ -77,6 +77,7 @@ public BlockDocIdIterator iterator() {
sortedDocIdI
Jackie-Jiang commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2867536578
Essentially query will get wrong result when `numSortedDocIdIterators +
numBitmapBasedDocIdIterators > 1`, where with existing code
`numBitmapBasedDocIdIterators` is always 0. So we
Jackie-Jiang commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2867518692
Wow, how did I miss this..
By reading the code, this would skip docs matched with bitmap and produce
wrong result if there are multiple filters on sorted column and some filters o
chenboat commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2867514588
Which AND among the two are you referring to?
> **What type of queries are impacted?** When we have a query of type `AND
(condition1 OR condition2) AND REGEXP_LIKE`, the AND pred
chenboat commented on PR #15756:
URL: https://github.com/apache/pinot/pull/15756#issuecomment-2867488836
+1 to Ankit comments to add tests to validate this PR and also prevents
future regression. We should have at least 1 test in the PR to show the
behavior change.
--
This is an automate
14 matches
Mail list logo
