tarun11Mavani commented on code in PR #15756:
URL: https://github.com/apache/pinot/pull/15756#discussion_r2083304445
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##########
@@ -77,6 +77,7 @@ public BlockDocIdIterator iterator() {
sortedDocIdIterators.add((SortedDocIdIterator) docIdIterator);
numEntriesScannedForNonScanBasedDocIdSets +=
docIdSet.getNumEntriesScannedInFilter();
} else if (docIdIterator instanceof BitmapBasedDocIdIterator) {
+ bitmapBasedDocIdIterators.add((BitmapBasedDocIdIterator)
docIdIterator);
Review Comment:
It can have performance issue as well as data correctness issue.
I have updated the [PR summary
](https://github.com/apache/pinot/pull/15756#issue-3052499511) with exact
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
