ankitsultana commented on code in PR #15756: URL: https://github.com/apache/pinot/pull/15756#discussion_r2085183246
########## pinot-core/src/test/java/org/apache/pinot/core/operator/docidsets/OrDocIdSetTest.java: ########## @@ -0,0 +1,137 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.docidsets; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import org.apache.pinot.core.common.BlockDocIdIterator; +import org.apache.pinot.core.common.BlockDocIdSet; +import org.apache.pinot.core.operator.dociditerators.BitmapDocIdIterator; +import org.apache.pinot.core.operator.dociditerators.OrDocIdIterator; +import org.apache.pinot.core.operator.dociditerators.SVScanDocIdIterator; +import org.apache.pinot.core.operator.dociditerators.SortedDocIdIterator; +import org.apache.pinot.spi.utils.Pairs; +import org.roaringbitmap.buffer.MutableRoaringBitmap; +import org.testng.annotations.Test; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; +import static org.testng.Assert.assertFalse; +import static org.testng.Assert.assertTrue; + + +public class OrDocIdSetTest { + @Test + public void iteratorReturnsBitmapDocIdIteratorWhenOnlyIndexBasedIteratorsExist() { Review Comment: @tarun11Mavani : just to confirm, you'll be working on adding E2E tests which verify correctness of query execution when complex filters are involved right? I think unit-tests in this case have limited value and increase maintenance overhead in the long run. We can still keep these, but the actual test we need in OSS is an E2E test which can test that the output rows after filters are applied are exactly as what I expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
