chenboat commented on PR #15756: URL: https://github.com/apache/pinot/pull/15756#issuecomment-2867488836
+1 to Ankit comments to add tests to validate this PR and also prevents future regression. We should have at least 1 test in the PR to show the behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
