Re: [PR] add metric for time retention failing due to end time [pinot]

Jackie-Jiang merged PR #13879: URL: https://github.com/apache/pinot/pull/13879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] add metric for time retention failing due to end time [pinot]

Jackie-Jiang commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1744366830 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java: ## @@ -318,6 +321,17 @@ private void updateSegmentMetrics(String ta

Re: [PR] add metric for time retention failing due to end time [pinot]

jadami10 commented on PR #13879: URL: https://github.com/apache/pinot/pull/13879#issuecomment-2327888469 > We do have a check in `TimeValidationTransformer` to check if the time value is in valid range. Can you double check why it is not triggered since you don't have `continueOnError` set

Re: [PR] add metric for time retention failing due to end time [pinot]

Jackie-Jiang commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1737152231 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/strategy/TimeRetentionStrategy.java: ## @@ -32,9 +34,11 @@ public class TimeRete

Re: [PR] add metric for time retention failing due to end time [pinot]

jadami10 commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1731646625 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void uploadToDee

Re: [PR] add metric for time retention failing due to end time [pinot]

tibrewalpratik17 commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1731368036 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void upl

Re: [PR] add metric for time retention failing due to end time [pinot]

jadami10 commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1731351530 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void uploadToDee

Re: [PR] add metric for time retention failing due to end time [pinot]

tibrewalpratik17 commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1731120929 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void upl

Re: [PR] add metric for time retention failing due to end time [pinot]

jadami10 commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1730163813 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void uploadToDee

Re: [PR] add metric for time retention failing due to end time [pinot]

vvivekiyer commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1729585015 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void uploadToD

Re: [PR] add metric for time retention failing due to end time [pinot]

codecov-commenter commented on PR #13879: URL: https://github.com/apache/pinot/pull/13879#issuecomment-2306071718 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13879?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u