tibrewalpratik17 commented on code in PR #13879:
URL: https://github.com/apache/pinot/pull/13879#discussion_r1731120929
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1505,7 +1505,7 @@ public void uploadToDeepStoreIfMissing(TableConfig
tableConfig, List<SegmentZKMe
long retentionMs =
TimeUnit.valueOf(validationConfig.getRetentionTimeUnit().toUpperCase())
.toMillis(Long.parseLong(validationConfig.getRetentionTimeValue()));
RetentionStrategy retentionStrategy = new
TimeRetentionStrategy(TimeUnit.MILLISECONDS,
- retentionMs -
MIN_TIME_BEFORE_SEGMENT_EXPIRATION_FOR_FIXING_DEEP_STORE_COPY_MILLIS);
+ retentionMs -
MIN_TIME_BEFORE_SEGMENT_EXPIRATION_FOR_FIXING_DEEP_STORE_COPY_MILLIS,
_controllerMetrics);
Review Comment:
Can we instead have this metric emission from
`SegmentStatusChecker#updateSegmentMetrics`? We already fetch segmentZKMetadata
over there as well and can easily validate this field.
We can also create a new periodic task - `SegmentZKMetadataValidator` and
easily extend it to have multiple validations in future. We can keep
retention-flow separate of this metadata-validation imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
