Jackie-Jiang commented on code in PR #13879:
URL: https://github.com/apache/pinot/pull/13879#discussion_r1737152231
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/strategy/TimeRetentionStrategy.java:
##########
@@ -32,9 +34,11 @@ public class TimeRetentionStrategy implements
RetentionStrategy {
private static final Logger LOGGER =
LoggerFactory.getLogger(TimeRetentionStrategy.class);
private final long _retentionMs;
+ private final ControllerMetrics _controllerMetrics;
- public TimeRetentionStrategy(TimeUnit timeUnit, long timeValue) {
+ public TimeRetentionStrategy(TimeUnit timeUnit, long timeValue,
ControllerMetrics controllerMetrics) {
_retentionMs = timeUnit.toMillis(timeValue);
+ _controllerMetrics = controllerMetrics;
Review Comment:
You may use `ControllerMetrics.get()` to get the `_controllerMetrics`. No
need to pass it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
