yashmayya commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067962738
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java:
##
@@ -252,7 +252,7 @@ public static DataBlock readFrom(ByteBuffer buffer)
pub
gortiz commented on PR #15571:
URL: https://github.com/apache/pinot/pull/15571#issuecomment-2840947479
> the BlockSplitter used in BlockExchange to split blocks based on rows
doesn't serve any other purpose than trying to keep the gRPC message size under
the max limit right? Any reason we
gortiz commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067940510
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java:
##
@@ -60,10 +63,15 @@ public void onNext(MailboxContent mailbox
gortiz commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067934786
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java:
##
@@ -252,7 +252,7 @@ public static DataBlock readFrom(ByteBuffer buffer)
public
gortiz commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067925293
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##
@@ -229,4 +254,64 @@ public DataBlock visit(ErrorMseBlock block,
List se
gortiz commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067918455
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##
@@ -402,7 +403,14 @@ public List serialize()
if (_serialized == null) {
yashmayya commented on PR #15571:
URL: https://github.com/apache/pinot/pull/15571#issuecomment-2840906511
> This PR creates a new splitting strategy on top of that based purely on
the block bytes payload. Both strategies can live simultaneously, although it
is expected that byte-based split
yashmayya commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2067868126
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##
@@ -402,7 +403,14 @@ public List serialize()
if (_serialized == null) {
KKcorps commented on code in PR #15641:
URL: https://github.com/apache/pinot/pull/15641#discussion_r2067910223
##
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConnectionHandler.java:
##
@@ -56,6 +56,
KKcorps commented on PR #15641:
URL: https://github.com/apache/pinot/pull/15641#issuecomment-2840896125
https://github.com/apache/pinot/pull/15641#discussion_r2067522671
This tbh is not needed anymore. We were not setting streamMetadatProvider as
null when closed and hence that instan
praveenc7 commented on code in PR #15350:
URL: https://github.com/apache/pinot/pull/15350#discussion_r2067885886
##
pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionOrderByOperator.java:
##
@@ -279,7 +279,13 @@ private SelectionResultsBlock computePartially
praveenc7 commented on PR #15585:
URL: https://github.com/apache/pinot/pull/15585#issuecomment-2840672393
> Can you help update the PR description and pinot documentation about the
new added metrics?
Sure will update
--
This is an automated message from the Apache Git Service.
To r
Jackie-Jiang commented on PR #15585:
URL: https://github.com/apache/pinot/pull/15585#issuecomment-2840578916
Can you help update the PR description and pinot documentation about the new
added metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1a476dea72 Add TableSegmentsInfo to Thrift and Pr
Jackie-Jiang closed issue #15558: [Logical Table] Add TableSegmentInfo List in
InstanceRequest thrift object
URL: https://github.com/apache/pinot/issues/15558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jackie-Jiang merged PR #15573:
URL: https://github.com/apache/pinot/pull/15573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang closed issue #15592: Controller schedules tasks for all tables,
instead of only the tables for which it is the lead.
URL: https://github.com/apache/pinot/issues/15592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
codecov-commenter commented on PR #15674:
URL: https://github.com/apache/pinot/pull/15674#issuecomment-2840494780
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15674?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
praveenc7 commented on issue #15675:
URL: https://github.com/apache/pinot/issues/15675#issuecomment-2840485276
cc : @vvivekiyer @siddharthteotia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
somandal opened a new pull request, #15674:
URL: https://github.com/apache/pinot/pull/15674
Found an issue where the rebalance progress stats can show a -ve value for
estimated time remaining when there are lingering carry over segments that
cause remaining segments to be added + carry over
Jackie-Jiang commented on code in PR #15641:
URL: https://github.com/apache/pinot/pull/15641#discussion_r2067522671
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1851,6 +1854,10 @@ private StreamPartitionMsgOffset
vvivekiyer commented on code in PR #15350:
URL: https://github.com/apache/pinot/pull/15350#discussion_r2065179730
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##
@@ -1730,6 +1730,7 @@ static void updateColumnNames
Jackie-Jiang commented on PR #15372:
URL: https://github.com/apache/pinot/pull/15372#issuecomment-2840387279
@priyen-stripe Don't remember the details, probably just best practice. Did
you run into issues trying to close the consumer multiple times?
--
This is an automated message from th
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.adobe.testing-s3mock-testcontainers-4.1.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was c22352d2f5 Bump com.adobe.testing:s3mock-testcontainers fr
dependabot[bot] closed pull request #15612: Bump
com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.1.1
URL: https://github.com/apache/pinot/pull/15612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
dependabot[bot] commented on PR #15612:
URL: https://github.com/apache/pinot/pull/15612#issuecomment-2840382150
OK, I won't notify you about version 4.x.x again, unless you re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Jackie-Jiang commented on PR #15612:
URL: https://github.com/apache/pinot/pull/15612#issuecomment-2840382071
@dependabot ignore this major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang closed issue #15454: Support CityHash function
URL: https://github.com/apache/pinot/issues/15454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.31
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 5f8419c38d Bump software.amazon.awssdk:bom from 2.31.30 to 2.31.31
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.31
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 827d03c70d Bump software.amazon.awssdk:bom from 2.31.30 to 2.31.31
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 16a477fda6 Bump com.azure:azure-sdk-bom from 1.2.33 to 1.2.34 (#15668)
add 77d0e9fc93 Bug fix: table names misalig
Jackie-Jiang merged PR #15670:
URL: https://github.com/apache/pinot/pull/15670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.34
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 49fe4f7b1d Bump com.azure:azure-sdk-bom from 1.2.33 to 1.2.34
The revisions t
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a57527dadc Bump org.apache.commons:commons-configuration2 from 2.11.0
to 2.12.0 (#15669)
add 16a477fda6 Bump com.
Jackie-Jiang merged PR #15668:
URL: https://github.com/apache/pinot/pull/15668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #15669:
URL: https://github.com/apache/pinot/pull/15669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.apache.commons-commons-configuration2-2.12.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 8fc2c5d4ca Bump org.apache.commons:commons-configuration2 f
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a57527dadc Bump org.apache.commons:commons-config
codecov-commenter commented on PR #15673:
URL: https://github.com/apache/pinot/pull/15673#issuecomment-2839810948
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
noob-se7en commented on PR #15673:
URL: https://github.com/apache/pinot/pull/15673#issuecomment-2839697425
@KKcorps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
noob-se7en opened a new pull request, #15673:
URL: https://github.com/apache/pinot/pull/15673
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
noob-se7en commented on PR #14217:
URL: https://github.com/apache/pinot/pull/14217#issuecomment-2839693930
Any reason to keep it behind a flag? Any issue with always resetting error
segments by default?
@shauryachats
--
This is an automated message from the Apache Git Service.
To res
vinodbaba commented on issue #15522:
URL: https://github.com/apache/pinot/issues/15522#issuecomment-2839526000
@yashmayya can i pick this up ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
albertobastos commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2066929427
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##
@@ -52,24 +58,35 @@
public class GrpcSendingMailbox implements Se
codecov-commenter commented on PR #15672:
URL: https://github.com/apache/pinot/pull/15672#issuecomment-2839465326
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15672?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
rajagopr closed pull request #15664: Support unnest on a string typed json
column
URL: https://github.com/apache/pinot/pull/15664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
xiangfu0 merged PR #15671:
URL: https://github.com/apache/pinot/pull/15671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3d46edb089 Kinesis partition split fixes (#15563)
add 4abddfc8ff Update helm chart for zookeeper storage class an
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch xiangfu0-patch-1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was e531e24492 Update helm chart for zookeeper storage class and size
The revisions that were on this branch ar
Copilot commented on code in PR #15672:
URL: https://github.com/apache/pinot/pull/15672#discussion_r2066768712
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java:
##
@@ -130,7 +130,14 @@ public void process(@Nullable
xiangfu0 opened a new pull request, #15672:
URL: https://github.com/apache/pinot/pull/15672
Currently, if the preprocessing failed to create index for a segment, it
will put the segment into ERROR state.
This behavior seems to be good, but in reality, it will fail a server
restart due to
codecov-commenter commented on PR #15671:
URL: https://github.com/apache/pinot/pull/15671#issuecomment-2839086239
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15671?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz commented on code in PR #15560:
URL: https://github.com/apache/pinot/pull/15560#discussion_r2066487002
##
.github/workflows/pinot_tests.yml:
##
@@ -78,19 +78,9 @@ jobs:
fail-fast: false
matrix:
testset: [ 1, 2 ]
-java: [ 11, 21 ]
+ja
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch xiangfu0-patch-1
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit e531e244925060d35ce4295c80b21ad42515b332
Author: Xiang Fu
AuthorDate: Tue Apr 29 06:28:50 2025 -0700
Upda
xiangfu0 opened a new pull request, #15671:
URL: https://github.com/apache/pinot/pull/15671
Update helm chart for zookeeper default storage class to "" and default size
to 8Gi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch xiangfu0-patch-1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at e531e24492 Update helm chart for zookeeper storage class and size
This branch includes the following new co
yashmayya commented on code in PR #15609:
URL: https://github.com/apache/pinot/pull/15609#discussion_r2065941687
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -1570,6 +1569,18 @@ public static class PlanVersions {
public static final Stri
codecov-commenter commented on PR #15670:
URL: https://github.com/apache/pinot/pull/15670#issuecomment-2838695357
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15670?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz commented on PR #15571:
URL: https://github.com/apache/pinot/pull/15571#issuecomment-2838694209
Given I've added some code, I would request another committer to approve
this PR as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
codecov-commenter commented on PR #15669:
URL: https://github.com/apache/pinot/pull/15669#issuecomment-2838594020
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15669?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #15668:
URL: https://github.com/apache/pinot/pull/15668#issuecomment-2838592327
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15668?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #15667:
URL: https://github.com/apache/pinot/pull/15667#issuecomment-2838589832
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15667?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
rsrkpatwari1234 commented on issue #15665:
URL: https://github.com/apache/pinot/issues/15665#issuecomment-2838576618
CPU profiler data -
[flamegraph.html.zip](https://github.com/user-attachments/files/19958017/flamegraph.html.zip)
for one of the pinot server nodes with high CPU utilization
KKcorps opened a new pull request, #15670:
URL: https://github.com/apache/pinot/pull/15670
for one of the pinot server nodes with high CPU utilization
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.commons-commons-configuration2-2.12.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 8fc2c5d4ca Bump org.apache.commons:commons-configuratio
dependabot[bot] opened a new pull request, #15669:
URL: https://github.com/apache/pinot/pull/15669
Bumps org.apache.commons:commons-configuration2 from 2.11.0 to 2.12.0.
[
from 1.2.33 to 1.2.34.
Commits
https://github.com/Azure/azure-sdk-for-java/commit/90f247db0f0c30255755
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.31
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 5f8419c38d Bump software.amazon.awssdk:bom from 2.31.30 to 2.31.31
N
dependabot[bot] opened a new pull request, #15667:
URL: https://github.com/apache/pinot/pull/15667
Bumps software.amazon.awssdk:bom from 2.31.30 to 2.31.31.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
gortiz commented on code in PR #15571:
URL: https://github.com/apache/pinot/pull/15571#discussion_r2065993917
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##
@@ -52,24 +58,35 @@
public class GrpcSendingMailbox implements SendingMa
YoavNordmann opened a new issue, #15666:
URL: https://github.com/apache/pinot/issues/15666
As per documentation available
[here](https://dev.startree.ai/docs/ingest-data/file-ingestion-task): I am
trying to use the `taskMaxNumFiles` parameter in my ingestion tasks, I came to
the conclusion
jayeshchoudhary commented on PR #15657:
URL: https://github.com/apache/pinot/pull/15657#issuecomment-2838108669
can you also add ss of how the screen looks and behaves for offline table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
jayeshchoudhary commented on code in PR #15657:
URL: https://github.com/apache/pinot/pull/15657#discussion_r2065923886
##
pinot-controller/src/main/resources/app/pages/TenantDetails.tsx:
##
@@ -635,10 +774,43 @@ const TenantPageDetails = ({ match }:
RouteComponentProps) => {
jayeshchoudhary commented on code in PR #15657:
URL: https://github.com/apache/pinot/pull/15657#discussion_r2065921535
##
pinot-controller/src/main/resources/app/pages/TenantDetails.tsx:
##
@@ -505,6 +550,68 @@ const TenantPageDetails = ({ match }:
RouteComponentProps) => {
YoavNordmann commented on issue #15659:
URL: https://github.com/apache/pinot/issues/15659#issuecomment-2838095937
IMHO, it seems to me the correct S3 Path description is with 2 slashes,
therefore it would seem odd to allows for a 'faulty' url.
I would urge to only accept the correct one,
xiangfu0 commented on code in PR #15606:
URL: https://github.com/apache/pinot/pull/15606#discussion_r2065864417
##
pinot-common/src/main/java/org/apache/pinot/common/cache/QueryCache.java:
##
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Copilot commented on code in PR #15606:
URL: https://github.com/apache/pinot/pull/15606#discussion_r2065851053
##
pinot-common/src/main/java/org/apache/pinot/common/cache/QueryCache.java:
##
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
KKcorps commented on PR #15563:
URL: https://github.com/apache/pinot/pull/15563#issuecomment-2837900400
Please raise another PR to clean up the newly introduced methods to trigger
realtime segment manager periodic task in test as that is already supported
--
This is an automated message f
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3d46edb089 Kinesis partition split fixes (#1
KKcorps merged PR #15563:
URL: https://github.com/apache/pinot/pull/15563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e544877e23 Support unnest on a string typed
KKcorps merged PR #15663:
URL: https://github.com/apache/pinot/pull/15663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
84 matches
Mail list logo
