swaminathanmanish commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1872726305
##
pinot-plugins/pinot-segment-writer/pinot-segment-writer-file-based/src/main/java/org/apache/pinot/plugin/segmentwriter/filebased/FileBasedSegmentWriter.java:
#
Jackie-Jiang commented on code in PR #14250:
URL: https://github.com/apache/pinot/pull/14250#discussion_r1872719243
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -840,6 +841,36 @@ public String getServerMetada
Jackie-Jiang commented on PR #14415:
URL: https://github.com/apache/pinot/pull/14415#issuecomment-2522272788
@jadami10 Are you using the spark job for the batch ingestion? It would be
good if you can help review this PR
--
This is an automated message from the Apache Git Service.
To respo
Jackie-Jiang commented on code in PR #14348:
URL: https://github.com/apache/pinot/pull/14348#discussion_r1872670210
##
pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ServerPrometheusMetricsTest.java:
##
@@ -148,6 +137,7 @@ public void gaugeTest(ServerGauge
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new dafb4f0180 Include column name for v4 raw fwd
yashmayya merged PR #14613:
URL: https://github.com/apache/pinot/pull/14613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
codecov-commenter commented on PR #14613:
URL: https://github.com/apache/pinot/pull/14613#issuecomment-2522160947
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14613?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
itschrispeck opened a new pull request, #14613:
URL: https://github.com/apache/pinot/pull/14613
It's useful to know which column caused the build failure so it may be
addressed more quickly by operators. Currently users are left to guess which
column caused the exception.
_dataBuffe
codecov-commenter commented on PR #14612:
URL: https://github.com/apache/pinot/pull/14612#issuecomment-2522028690
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14612?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
tibrewalpratik17 commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1872508315
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.jav
jadami10 opened a new pull request, #14612:
URL: https://github.com/apache/pinot/pull/14612
This is an API enhancement so servers give a reason for why time boundary
advance failing. We've found with tables wtih 10k+ segments, this API will
repeatedly fail, but there's no way to debug what
jasperjiaguo commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1872437742
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##
@@ -330,46 +336,49 @@ private void updateSegmentMetrics(String
t
jasperjiaguo commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1872436974
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##
@@ -330,46 +336,49 @@ private void updateSegmentMetrics(String
t
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3cb3c54630 RefreshSegmentTask - Support for scheduling adhoc tasks
(#14596)
add 70c9898315 Fix integer overflow i
Jackie-Jiang merged PR #14610:
URL: https://github.com/apache/pinot/pull/14610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
codecov-commenter commented on PR #14611:
URL: https://github.com/apache/pinot/pull/14611#issuecomment-2521835328
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14611?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #14610:
URL: https://github.com/apache/pinot/pull/14610#issuecomment-2521833518
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14610?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ankitsultana opened a new pull request, #14611:
URL: https://github.com/apache/pinot/pull/14611
TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
jiaguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3cb3c54630 RefreshSegmentTask - Support for sched
Jackie-Jiang opened a new pull request, #14610:
URL: https://github.com/apache/pinot/pull/14610
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jasperjiaguo merged PR #14596:
URL: https://github.com/apache/pinot/pull/14596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
klsince commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1872298945
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java:
#
raghavyadav01 commented on code in PR #14609:
URL: https://github.com/apache/pinot/pull/14609#discussion_r1872285256
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/map/MapIndexType.java:
##
@@ -55,6 +55,7 @@ public class MapIndexType extends
A
xiangfu0 commented on code in PR #14609:
URL: https://github.com/apache/pinot/pull/14609#discussion_r1872263570
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/map/MapIndexType.java:
##
@@ -55,6 +55,7 @@ public class MapIndexType extends
Abstra
codecov-commenter commented on PR #14609:
URL: https://github.com/apache/pinot/pull/14609#issuecomment-2521632414
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14609?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ankitsultana commented on code in PR #14598:
URL: https://github.com/apache/pinot/pull/14598#discussion_r1872257870
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##
@@ -261,15 +264,15 @@ public void processTimeSeriesQuery(String serialized
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 0e1c12ff46 Marks end criteria reached for the segment if the Index
cannot consume more rows (#14479)
add 1c
ankitsultana merged PR #14598:
URL: https://github.com/apache/pinot/pull/14598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
raghavyadav01 commented on code in PR #14598:
URL: https://github.com/apache/pinot/pull/14598#discussion_r1872226477
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##
@@ -261,15 +264,15 @@ public void processTimeSeriesQuery(String serialize
raghavyadav01 commented on PR #14598:
URL: https://github.com/apache/pinot/pull/14598#issuecomment-2521578573
Overall LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ankitsultana commented on code in PR #14598:
URL: https://github.com/apache/pinot/pull/14598#discussion_r1872232274
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/PhysicalTimeSeriesServerPlanVisitor.java:
##
@@ -42,17 +42,14 @@
import org.apache.
ankitsultana commented on code in PR #14598:
URL: https://github.com/apache/pinot/pull/14598#discussion_r1872231241
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##
@@ -261,15 +264,15 @@ public void processTimeSeriesQuery(String serialized
raghavyadav01 opened a new pull request, #14609:
URL: https://github.com/apache/pinot/pull/14609
Making mutable Index class pluggable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
codecov-commenter commented on PR #14608:
URL: https://github.com/apache/pinot/pull/14608#issuecomment-2521397619
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14608?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on code in PR #14602:
URL: https://github.com/apache/pinot/pull/14602#discussion_r1872007205
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java:
##
@@ -234,30 +235,44 @@ public void
testApplic
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0e1c12ff46 Marks end criteria reached for the seg
xiangfu0 opened a new pull request, #14608:
URL: https://github.com/apache/pinot/pull/14608
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Jackie-Jiang merged PR #14479:
URL: https://github.com/apache/pinot/pull/14479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #14606:
URL: https://github.com/apache/pinot/pull/14606#issuecomment-2521288578
Let's skip this version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
felpasl opened a new issue, #14607:
URL: https://github.com/apache/pinot/issues/14607
First, I want to express my gratitude for your hard work on the Apache Pinot
project. It has been an invaluable tool for our data analytics needs, and we
greatly appreciate the continuous improvements and
Jackie-Jiang commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1871916257
##
pinot-spi/src/main/java/org/apache/pinot/spi/recordtransformer/enricher/RecordEnricher.java:
##
@@ -16,25 +16,26 @@
* specific language governing permissions
suddendust commented on PR #14348:
URL: https://github.com/apache/pinot/pull/14348#issuecomment-2521143036
>Wondering why you don't need to explicitly specify pattern for other gauges?
@Jackie-Jiang We do have patterns for gauges too, ex:
```
- pattern:
"\"org\\.apache\\.pin
Jackie-Jiang commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1871905883
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##
@@ -82,12 +90,37 @@ public class CompositeTrans
tibrewalpratik17 commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1871891863
##
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##
@@ -199,4 +200,59 @@ public static class UpsertCompactionTask {
*/
tibrewalpratik17 commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1871892606
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.jav
yashmayya commented on PR #14606:
URL: https://github.com/apache/pinot/pull/14606#issuecomment-2520827827
The version was aligned in the earlier bom -
https://mvnrepository.com/artifact/com.google.cloud/libraries-bom/26.50.0,
https://mvnrepository.com/artifact/com.google.cloud/google-cloud-
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5104565882 Bump com.azure:azure-sdk-bom from 1
yashmayya merged PR #14605:
URL: https://github.com/apache/pinot/pull/14605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch
dependabot/maven/com.azure-azure-sdk-bom-1.2.30
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 02bf8f3f65 Bump com.azure:azure-sdk-bom from 1.2.29 to 1.2.30
The revisio
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 95b075b527 Batch reload api to specify what segment
klsince merged PR #14544:
URL: https://github.com/apache/pinot/pull/14544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
jadami10 commented on PR #14348:
URL: https://github.com/apache/pinot/pull/14348#issuecomment-2520479304
We made our own metrics template that's effectively identical to these. Most
metrics can be exported with reusable regex. But some of them are impossible to
do because table name (withou
yashmayya merged PR #14604:
URL: https://github.com/apache/pinot/pull/14604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.azure-azure-sdk-bom-1.2.30
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 5fae30912f Bump com.azure:azure-sdk-bom from 1.2.29 to 1.2.30
add 64
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 64a952f2d2 Bump software.amazon.awssdk:bom fro
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.29.29
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 7128d8056e Bump software.amazon.awssdk:bom from 2.29.27 to 2.29.29
Th
yashmayya commented on PR #14605:
URL: https://github.com/apache/pinot/pull/14605#issuecomment-2520248449
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.google.cloud-libraries-bom-26.51.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 558be3b8db Bump com.google.cloud:libraries-bom from 26.50.0 to 26
dependabot[bot] opened a new pull request, #14605:
URL: https://github.com/apache/pinot/pull/14605
Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java)
from 1.2.29 to 1.2.30.
Release notes
Sourced from https://github.com/azure/azure-sdk-for-java/releases";>c
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.azure-azure-sdk-bom-1.2.30
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 5fae30912f Bump com.azure:azure-sdk-bom from 1.2.29 to 1.2.30
No new rev
dependabot[bot] opened a new pull request, #14606:
URL: https://github.com/apache/pinot/pull/14606
Bumps
[com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom)
from 26.50.0 to 26.51.0.
Release notes
Sourced from https://github.com/googleapis/java-cloud-bom/
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.29.29
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 7128d8056e Bump software.amazon.awssdk:bom from 2.29.27 to 2.29.29
N
dependabot[bot] opened a new pull request, #14604:
URL: https://github.com/apache/pinot/pull/14604
Bumps software.amazon.awssdk:bom from 2.29.27 to 2.29.29.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
swaminathanmanish commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1871192791
##
pinot-spi/src/main/java/org/apache/pinot/spi/recordtransformer/enricher/RecordEnricher.java:
##
@@ -16,25 +16,26 @@
* specific language governing permiss
swaminathanmanish commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1871192791
##
pinot-spi/src/main/java/org/apache/pinot/spi/recordtransformer/enricher/RecordEnricher.java:
##
@@ -16,25 +16,26 @@
* specific language governing permiss
swaminathanmanish commented on code in PR #14601:
URL: https://github.com/apache/pinot/pull/14601#discussion_r1871192791
##
pinot-spi/src/main/java/org/apache/pinot/spi/recordtransformer/enricher/RecordEnricher.java:
##
@@ -16,25 +16,26 @@
* specific language governing permiss
davecromberge commented on code in PR #14373:
URL: https://github.com/apache/pinot/pull/14373#discussion_r1871155580
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskUtils.java:
##
@@ -45
davecromberge commented on code in PR #14373:
URL: https://github.com/apache/pinot/pull/14373#discussion_r1871155071
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskUtils.java:
##
@@ -45
davecromberge commented on PR #14373:
URL: https://github.com/apache/pinot/pull/14373#issuecomment-2519960660
@swaminathanmanish let's break it into multiple PRs as that would make the
review process easier. You are correct - I only intend to build upon what I
have here.
I do have t
swaminathanmanish commented on PR #14373:
URL: https://github.com/apache/pinot/pull/14373#issuecomment-2519872419
> > > NOTE: This PR is a work in progress and has been created to
demonstrate the concept
> >
> >
> > This is ready for review ?
>
> This is ready for review bu
swaminathanmanish commented on code in PR #14373:
URL: https://github.com/apache/pinot/pull/14373#discussion_r1871045842
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskUtils.java:
##
@@
swaminathanmanish commented on code in PR #14373:
URL: https://github.com/apache/pinot/pull/14373#discussion_r1871045842
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskUtils.java:
##
@@
bziobrowski commented on code in PR #14602:
URL: https://github.com/apache/pinot/pull/14602#discussion_r1870908957
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java:
##
@@ -234,30 +235,44 @@ public void
testApplica
tibrewalpratik17 commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1870891393
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.jav
tibrewalpratik17 commented on issue #14483:
URL: https://github.com/apache/pinot/issues/14483#issuecomment-2519526331
Copying from comment -
https://github.com/apache/pinot/pull/14596/files#r1870200378
One improvement in this task can be to keep the default number of tasks
execution
75 matches
Mail list logo
