ankitsultana commented on code in PR #14598:
URL: https://github.com/apache/pinot/pull/14598#discussion_r1872257870
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -261,15 +264,15 @@ public void processTimeSeriesQuery(String serializedPlan,
Map<String, String> me
responseObserver.onCompleted();
};
try {
- final long timeoutMs = extractTimeoutMs(metadata);
- Preconditions.checkState(timeoutMs > 0,
- "Query timed out before getting processed in server. Remaining time:
%s", timeoutMs);
+ final long deadlineMs = extractDeadlineMs(metadata);
+ Preconditions.checkState(System.currentTimeMillis() < deadlineMs,
+ "Query timed out before getting processed in server. Remaining time:
%s", deadlineMs);
Review Comment:
self-review: remaining time is incorrect. will fix it in the PR I am raising
in a few minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
