swaminathanmanish commented on PR #14373: URL: https://github.com/apache/pinot/pull/14373#issuecomment-2519872419
> > > NOTE: This PR is a work in progress and has been created to demonstrate the concept > > > > > > This is ready for review ? > > This is ready for review but it stops short of introducing the parameters for every single aggregator function. Since initial feedback seems positive, I will include the additional sketches in this PR shortly. Im assuming these will additional sketch params building on top of what you have now right? If it makes sense, you can break this into 2 PRs as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
