Re: [I] Support new data type: `TimestampWithTimeZone` [pinot]

2024-11-22 Thread via GitHub
mghildiy commented on issue #13004: URL: https://github.com/apache/pinot/issues/13004#issuecomment-2495335139 [This](https://github.com/apache/pinot/pull/14526) is the PR I have created. It's a WIP currently. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Adding more derived json parsed columns in QuickStart example [pinot]

2024-11-22 Thread via GitHub
codecov-commenter commented on PR #14525: URL: https://github.com/apache/pinot/pull/14525#issuecomment-2495230526 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14525?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] Support for S3A Connector [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang commented on issue #14312: URL: https://github.com/apache/pinot/issues/14312#issuecomment-2495164236 Support added in #14474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [WIP] Introduce PinotLogicalJoin to encapsulate join strategy [pinot]

2024-11-22 Thread via GitHub
codecov-commenter commented on PR #14524: URL: https://github.com/apache/pinot/pull/14524#issuecomment-2495229198 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14524?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [Multi-stage] Allow filter for lookup JOIN [pinot]

2024-11-22 Thread via GitHub
codecov-commenter commented on PR #14523: URL: https://github.com/apache/pinot/pull/14523#issuecomment-2495225934 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14523?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [Multi-stage] Allow filter for lookup JOIN [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang opened a new pull request, #14523: URL: https://github.com/apache/pinot/pull/14523 Customize the following 2 rules to not push down filters/transforms for lookup JOIN: - `CoreRules.FILTER_INTO_JOIN` and `CoreRules.JOIN_CONDITION_PUSH`: Do not push down filter to right table,

[PR] Adding more derived json parsed columns in QuickStart example [pinot]

2024-11-22 Thread via GitHub
xiangfu0 opened a new pull request, #14525: URL: https://github.com/apache/pinot/pull/14525 add more jsonPath examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] Security Concerns in the Pinot Docker Image and Java Depedencies [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang commented on issue #10311: URL: https://github.com/apache/pinot/issues/10311#issuecomment-2495161769 All the vulnerable dependencies are upgraded. Closing this ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [WIP] Introduce PinotLogicalJoin to encapsulate join strategy [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang opened a new pull request, #14524: URL: https://github.com/apache/pinot/pull/14524 Add `PinotLogicalJoin` to encapsulate join strategy instead of parsing it from hints in the rules -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Security Concerns in the Pinot Docker Image and Java Depedencies [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang closed issue #10311: Security Concerns in the Pinot Docker Image and Java Depedencies URL: https://github.com/apache/pinot/issues/10311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Support for S3A Connector [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang closed issue #14312: Support for S3A Connector URL: https://github.com/apache/pinot/issues/14312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [I] Downstream Dependencies of org.apache.pinot : pinot-jdbc-client : 0.12.1 have serious vulnerabilities [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang commented on issue #11060: URL: https://github.com/apache/pinot/issues/11060#issuecomment-2495161884 All the vulnerable dependencies are upgraded. Closing this ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Downstream Dependencies of org.apache.pinot : pinot-jdbc-client : 0.12.1 have serious vulnerabilities [pinot]

2024-11-22 Thread via GitHub
Jackie-Jiang closed issue #11060: Downstream Dependencies of org.apache.pinot : pinot-jdbc-client : 0.12.1 have serious vulnerabilities URL: https://github.com/apache/pinot/issues/11060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Add a flexible json config way [pinot]

2024-11-22 Thread via GitHub
chenboat merged PR #14229: URL: https://github.com/apache/pinot/pull/14229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: Add a flexible json config way (#14229)

2024-11-22 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ca78729254 Add a flexible json config way (#142

[PR] Update H3IndexConfig.java [pinot]

2024-11-22 Thread via GitHub
meshari343 opened a new pull request, #14522: URL: https://github.com/apache/pinot/pull/14522 updates variable "resolution" to "resolutions" to match documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [timeseries] Response Size Limit, Metrics and Series Limit [pinot]

2024-11-22 Thread via GitHub
ankitsultana merged PR #14501: URL: https://github.com/apache/pinot/pull/14501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: [timeseries] Response Size Limit, Metrics and Series Limit (#14501)

2024-11-22 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f0c6bba73c [timeseries] Response Size Limit

Re: [PR] [timeseries] Response Size Limit, Metrics and Series Limit [pinot]

2024-11-22 Thread via GitHub
ankitsultana commented on code in PR #14501: URL: https://github.com/apache/pinot/pull/14501#discussion_r1854560852 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/TimeSeriesBuilderFactory.java: ## @@ -25,12 +25,26 @@ public abstract

Re: [PR] [timeseries] Response Size Limit, Metrics and Series Limit [pinot]

2024-11-22 Thread via GitHub
ankitsultana commented on code in PR #14501: URL: https://github.com/apache/pinot/pull/14501#discussion_r1854559783 ## pinot-core/src/main/java/org/apache/pinot/core/plan/TimeSeriesPlanNode.java: ## @@ -66,7 +66,8 @@ _segmentContext, _queryContext, getProjectPlanNodeExpressions

Re: [PR] [timeseries] Response Size Limit, Metrics and Series Limit [pinot]

2024-11-22 Thread via GitHub
ankitsultana commented on code in PR #14501: URL: https://github.com/apache/pinot/pull/14501#discussion_r1854559300 ## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/merger/TimeSeriesAggResultsBlockMerger.java: ## @@ -44,6 +49,14 @@ public void mergeResultsBlock

Re: [PR] [timeseries] Response Size Limit, Metrics and Series Limit [pinot]

2024-11-22 Thread via GitHub
ankitsultana commented on code in PR #14501: URL: https://github.com/apache/pinot/pull/14501#discussion_r1854559532 ## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/merger/TimeSeriesAggResultsBlockMerger.java: ## @@ -44,6 +49,14 @@ public void mergeResultsBlock

Re: [PR] [timeseries] Response Size Limit, Metrics and Series Limit [pinot]

2024-11-22 Thread via GitHub
raghavyadav01 commented on code in PR #14501: URL: https://github.com/apache/pinot/pull/14501#discussion_r1854360422 ## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/merger/TimeSeriesAggResultsBlockMerger.java: ## @@ -44,6 +49,14 @@ public void mergeResultsBloc

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1854163236 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return need

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1854163236 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return need

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1854166400 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return need

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-22 Thread via GitHub
KKcorps commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1853916253 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return nee

Re: [PR] Configurable sketch accuracy in merge rollup task [pinot]

2024-11-22 Thread via GitHub
davecromberge commented on code in PR #14373: URL: https://github.com/apache/pinot/pull/14373#discussion_r1853925063 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/DistinctCountCPCSketchAggregator.java: ## @@ -30,7 +31,7 @@ public DistinctCountCP

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-22 Thread via GitHub
KKcorps commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1853913780 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return nee

(pinot) branch dependabot/maven/log4j.version-2.24.2 deleted (was fc1a0c0d62)

2024-11-22 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch dependabot/maven/log4j.version-2.24.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was fc1a0c0d62 Bump log4j.version from 2.24.1 to 2.24.2 The revisions that were on this bra

Re: [PR] Bump log4j.version from 2.24.1 to 2.24.2 [pinot]

2024-11-22 Thread via GitHub
tibrewalpratik17 merged PR #14519: URL: https://github.com/apache/pinot/pull/14519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch master updated (f755f6bb2c -> 4973abf40d)

2024-11-22 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from f755f6bb2c Bump software.amazon.awssdk:bom from 2.29.18 to 2.29.19 (#14520) add 4973abf40d Bump log4j.version fro

Re: [PR] [WIP] Minion task observability refactors [pinot]

2024-11-22 Thread via GitHub
codecov-commenter commented on PR #14521: URL: https://github.com/apache/pinot/pull/14521#issuecomment-2493762499 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14521?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853759039 ## docs/dev/query/msq/tree-lifecycle.md: ## @@ -0,0 +1,99 @@ +# Query tree lifecycle + +As usual in parsers and compilers, the query is transformed from a string to

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.29.18 to 2.29.19 (#14520)

2024-11-22 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f755f6bb2c Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.18 to 2.29.19 [pinot]

2024-11-22 Thread via GitHub
tibrewalpratik17 merged PR #14520: URL: https://github.com/apache/pinot/pull/14520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.19 deleted (was 5923d2776b)

2024-11-22 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.19 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5923d2776b Bump software.amazon.awssdk:bom from 2.29.18 to 2.29.19 The r

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
gortiz commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853860601 ## docs/dev/query/msq/execution.md: ## @@ -0,0 +1,48 @@ +# Multi stage query execution Review Comment: You are totally right. We need to more discipline to use alway

[PR] [WIP] Minion task observability refactors [pinot]

2024-11-22 Thread via GitHub
shounakmk219 opened a new pull request, #14521: URL: https://github.com/apache/pinot/pull/14521 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-22 Thread via GitHub
KKcorps commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1853838884 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return nee

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853802987 ## docs/dev/query/msq/execution.md: ## @@ -0,0 +1,48 @@ +# Multi stage query execution Review Comment: I think it would be good to: - decide on a single term

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853796560 ## docs/dev/query/msq/tree-lifecycle.md: ## @@ -0,0 +1,99 @@ +# Query tree lifecycle + +As usual in parsers and compilers, the query is transformed from a string to

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853802987 ## docs/dev/query/msq/execution.md: ## @@ -0,0 +1,48 @@ +# Multi stage query execution Review Comment: I think it would be good to: - decide on a single term

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853798339 ## docs/dev/query/msq/execution.md: ## @@ -0,0 +1,48 @@ +# Multi stage query execution + Review Comment: Shouldn't it point to `tree-lifecycle.md` ? -- This

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853792225 ## docs/dev/query/msq/tree-lifecycle.md: ## @@ -0,0 +1,99 @@ +# Query tree lifecycle + +As usual in parsers and compilers, the query is transformed from a string to

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853781530 ## docs/dev/query/msq/tree-lifecycle.md: ## @@ -0,0 +1,99 @@ +# Query tree lifecycle + +As usual in parsers and compilers, the query is transformed from a string to

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853738406 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handleReq

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853770707 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handle

[PR] Bump software.amazon.awssdk:bom from 2.29.18 to 2.29.19 [pinot]

2024-11-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14520: URL: https://github.com/apache/pinot/pull/14520 Bumps software.amazon.awssdk:bom from 2.29.18 to 2.29.19. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853770707 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handle

(pinot) branch dependabot/maven/log4j.version-2.24.2 created (now fc1a0c0d62)

2024-11-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/log4j.version-2.24.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at fc1a0c0d62 Bump log4j.version from 2.24.1 to 2.24.2 No new revisions were added by

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.19 created (now 5923d2776b)

2024-11-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.19 in repository https://gitbox.apache.org/repos/asf/pinot.git at 5923d2776b Bump software.amazon.awssdk:bom from 2.29.18 to 2.29.19 N

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853762300 ## docs/dev/query/msq/tree-lifecycle.md: ## @@ -0,0 +1,99 @@ +# Query tree lifecycle + +As usual in parsers and compilers, the query is transformed from a string to

[PR] Bump log4j.version from 2.24.1 to 2.24.2 [pinot]

2024-11-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14519: URL: https://github.com/apache/pinot/pull/14519 Bumps `log4j.version` from 2.24.1 to 2.24.2. Updates `org.apache.logging.log4j:log4j-api` from 2.24.1 to 2.24.2 Updates `org.apache.logging.log4j:log4j-core` from 2.24.1 to 2.24.2

Re: [PR] Introduce dev-docs [pinot]

2024-11-22 Thread via GitHub
bziobrowski commented on code in PR #14346: URL: https://github.com/apache/pinot/pull/14346#discussion_r1853762300 ## docs/dev/query/msq/tree-lifecycle.md: ## @@ -0,0 +1,99 @@ +# Query tree lifecycle + +As usual in parsers and compilers, the query is transformed from a string to

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853738406 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handleReq

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853731416 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BrokerQueryLimitTest.java: ## @@ -0,0 +1,189 @@ +/** + * Licensed to the Apache Software F

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853727146 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BrokerQueryLimitTest.java: ## @@ -0,0 +1,189 @@ +/** + * Licensed to the Apache Software F

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853726290 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BrokerQueryLimitTest.java: ## @@ -0,0 +1,189 @@ +/** + * Licensed to the Apache Software F

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853724818 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handle

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853718879 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BrokerQueryLimitTest.java: ## @@ -0,0 +1,189 @@ +/** + * Licensed to the Apache Software Foun

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
vrajat commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853716998 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handleReq

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2024-11-22 Thread via GitHub
yashmayya commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1853704897 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +313,10 @@ protected BrokerResponse handle

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.18 deleted (was 4d501eba49)

2024-11-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.18 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4d501eba49 Bump software.amazon.awssdk:bom from 2.29.17 to 2.29.18 Th

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.29.17 to 2.29.18 (#14514)

2024-11-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2d076d44b8 Bump software.amazon.awssdk:bom fro

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.17 to 2.29.18 [pinot]

2024-11-22 Thread via GitHub
yashmayya merged PR #14514: URL: https://github.com/apache/pinot/pull/14514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Extend the merge rollup task capabilities [pinot]

2024-11-22 Thread via GitHub
davecromberge commented on code in PR #14355: URL: https://github.com/apache/pinot/pull/14355#discussion_r1853649707 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/DimensionValueTransformer.java: ## @

Re: [PR] Extend the merge rollup task capabilities [pinot]

2024-11-22 Thread via GitHub
davecromberge commented on code in PR #14355: URL: https://github.com/apache/pinot/pull/14355#discussion_r1853649707 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/DimensionValueTransformer.java: ## @

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-22 Thread via GitHub
shounakmk219 commented on code in PR #14414: URL: https://github.com/apache/pinot/pull/14414#discussion_r1853639186 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java: ## @@ -43,24 +44,25 @@ private AccessControlUtils() { /**

Re: [PR] restrict UploadedRealtimeSegmentName upload to realtime table [pinot]

2024-11-22 Thread via GitHub
tibrewalpratik17 merged PR #14508: URL: https://github.com/apache/pinot/pull/14508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p