vrajat commented on code in PR #14452:
URL: https://github.com/apache/pinot/pull/14452#discussion_r1853738406
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -308,6 +313,10 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ if (isDefaultQueryResponseLimitEnabled() && !pinotQuery.isSetLimit()) {
Review Comment:
IIUC, the new behaviour will be:
If query does not have a limit clause:
* Limit will be 10.
* If a config parameter with `default` in it is set, then the limit will be
set to config value
Finally, limit will be overriden by a config param with override in its name.
My suggestion is to remove _Limit will be 10_ statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
