yashmayya commented on code in PR #14452:
URL: https://github.com/apache/pinot/pull/14452#discussion_r1853770707
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -308,6 +313,10 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ if (isDefaultQueryResponseLimitEnabled() && !pinotQuery.isSetLimit()) {
Review Comment:
~That's not backward compatible though, the v1 engine has always had a
default limit of 10 for queries with no explicit limit set and we can't really
safely change that.~
Nvm, I think I misunderstood you and you're actually proposing the same
thing as me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
