ankitsultana commented on code in PR #14501:
URL: https://github.com/apache/pinot/pull/14501#discussion_r1854559300
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/merger/TimeSeriesAggResultsBlockMerger.java:
##########
@@ -44,6 +49,14 @@ public void mergeResultsBlocks(TimeSeriesResultsBlock
mergedBlock, TimeSeriesRes
BaseTimeSeriesBuilder newTimeSeriesToMerge = entry.getValue();
if (currentTimeSeriesBuilder == null) {
currentTimeSeriesBlock.getSeriesBuilderMap().put(seriesHash,
newTimeSeriesToMerge);
+ final long currentUniqueSeries =
currentTimeSeriesBlock.getSeriesBuilderMap().size();
+ final long numBuckets =
currentTimeSeriesBlock.getTimeBuckets().getNumBuckets();
+ Preconditions.checkState(currentUniqueSeries * numBuckets <=
_maxDataPointsLimit,
Review Comment:
yeah across all unique series. Per series limits should be defined either in
your proxy or in your TimeSeriesLogicalPlanner, since that's basically defined
by TimeBuckets.length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
