codecov-commenter commented on PR #14324:
URL: https://github.com/apache/pinot/pull/14324#issuecomment-2443315765
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14324?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1820124388
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java:
##
@@ -78,12 +86,73 @@ private List processRo
yashmayya opened a new pull request, #14324:
URL: https://github.com/apache/pinot/pull/14324
- See related discussion here -
https://github.com/apache/pinot/pull/14264#discussion_r1818218038
- Minor refactor to use the same logic for `ROWS` / `RANGE` with the `IGNORE
NULLS` option when t
chrajeshbabu commented on issue #14312:
URL: https://github.com/apache/pinot/issues/14312#issuecomment-2443200106
Hi @alguiguilo098
@Jackie-Jiang @mayankshriv are the right people to guide and help to you
to contribute some meaningful work to this community.
Thanks
--
This is an
praveenc7 commented on code in PR #14001:
URL: https://github.com/apache/pinot/pull/14001#discussion_r1819929776
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java:
##
@@ -127,6 +139,48 @@ public DefaultGroupByExecutor(QueryCo
praveenc7 commented on code in PR #14001:
URL: https://github.com/apache/pinot/pull/14001#discussion_r1819929596
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java:
##
@@ -127,6 +139,48 @@ public DefaultGroupByExecutor(QueryCo
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3057f1ad7b Add isEqualSet Function (#14313)
3057f
Jackie-Jiang merged PR #14313:
URL: https://github.com/apache/pinot/pull/14313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
vvivekiyer commented on PR #14300:
URL: https://github.com/apache/pinot/pull/14300#issuecomment-2442892388
> But for Upserts I think one of the biggest cost is recomputing the
validDocId map, so for Upsert tables we won't see any specific benefits right?
(outside of the ones which are appli
codecov-commenter commented on PR #14323:
URL: https://github.com/apache/pinot/pull/14323#issuecomment-2442799030
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14323?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ashishjayamohan commented on PR #14322:
URL: https://github.com/apache/pinot/pull/14322#issuecomment-2442856038
Definitely, here's what I'm seeing when running the tests locally
(specifically after running
`testSparkSegmentMetadataPushWithoutConsistentPushWithBatchSegmentUpload`:
```
Jackie-Jiang merged PR #14264:
URL: https://github.com/apache/pinot/pull/14264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6fd21f28cb Add IGNORE NULLS option to FIRST_VALUE
Jackie-Jiang commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1819891616
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java:
##
@@ -78,12 +86,73 @@ private List proces
ashishjayamohan commented on code in PR #14313:
URL: https://github.com/apache/pinot/pull/14313#discussion_r1819883986
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/EqualityUtils.java:
##
@@ -156,9 +156,12 @@ public static boolean isEqualIgnoreOrder(@Nullable List
left,
Jackie-Jiang commented on PR #14322:
URL: https://github.com/apache/pinot/pull/14322#issuecomment-2442842539
Can you share the stack trace or error log of the failure?
`buildSegmentFromAvro()` is not touching helix, so that shouldn't be the root
cause
--
This is an automated message from
Jackie-Jiang commented on code in PR #14313:
URL: https://github.com/apache/pinot/pull/14313#discussion_r1819878344
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/EqualityUtils.java:
##
@@ -156,9 +156,12 @@ public static boolean isEqualIgnoreOrder(@Nullable List
left, @N
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a5a5d7bca4 Remove unnecessary plugin version ove
xiangfu0 merged PR #14323:
URL: https://github.com/apache/pinot/pull/14323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
jasperjiaguo commented on code in PR #14001:
URL: https://github.com/apache/pinot/pull/14001#discussion_r1819454034
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java:
##
@@ -127,6 +139,48 @@ public DefaultGroupByExecutor(Quer
Jackie-Jiang commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1819836993
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java:
##
@@ -42,14 +46,26 @@ public abstract clas
bziobrowski commented on PR #14298:
URL: https://github.com/apache/pinot/pull/14298#issuecomment-2442791269
Sure, when bucketing time zone is used then it behaves more like with SDF
output before the change -
e.g. date is truncated to 5 hours within the day and not to 5 hours counting
h
codecov-commenter commented on PR #14322:
URL: https://github.com/apache/pinot/pull/14322#issuecomment-2442786374
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14322?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ashishjayamohan commented on PR #14322:
URL: https://github.com/apache/pinot/pull/14322#issuecomment-2442748724
@Jackie-Jiang This PR addresses the issue with local tests that I ran into
[here](https://github.com/apache/pinot/pull/14199). Instead of being an issue
with the test priorities a
Jackie-Jiang commented on PR #14298:
URL: https://github.com/apache/pinot/pull/14298#issuecomment-2442737724
Can you elaborate more on this:
```
Note: when bucketing time zone is set, bucketing is performed relative to
bigger time unit (e.g. 1 day when bucketing to 1 hour ) and not epo
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/npm_and_yarn/pinot-controller/src/main/resources/elliptic-6.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was b6d6955d87 Bump elliptic in /pinot-controller/src/
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e827666091 Bump elliptic in /pinot-controller/src
Jackie-Jiang merged PR #14321:
URL: https://github.com/apache/pinot/pull/14321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #14322:
URL: https://github.com/apache/pinot/pull/14322#issuecomment-2442720086
Any idea why we need to add a sleep? Everything seems happen locally in a
synchronous fashion
--
This is an automated message from the Apache Git Service.
To respond to the message
Jackie-Jiang merged PR #14320:
URL: https://github.com/apache/pinot/pull/14320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was f4bcf8b577 Bump org.apache.maven.plugins:maven-jxr-plugin fr
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 86fd14e5be Bump org.apache.maven.plugins:maven-jx
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.github.luben-zstd-jni-1.5.6-7
in repository https://gitbox.apache.org/repos/asf/pinot.git
was c9fbd38d71 Bump com.github.luben:zstd-jni from 1.5.6-6 to 1.5.6-7
The rev
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from d5bcd780ac Bump com.puppycrawl.tools:checkstyle from 10.18.2 to
10.19.0 (#14317)
add 158db9a8da Bump com.github.l
Jackie-Jiang merged PR #14319:
URL: https://github.com/apache/pinot/pull/14319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang closed pull request #14318: Bump
org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.1
URL: https://github.com/apache/pinot/pull/14318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Jackie-Jiang commented on PR #14318:
URL: https://github.com/apache/pinot/pull/14318#issuecomment-2442699213
Follow parent plugin version: #14323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang opened a new pull request, #14323:
URL: https://github.com/apache/pinot/pull/14323
This plugin is already configured in the parent apache POM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-dependency-plugin-3.8.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was d26d6df9d4 Bump org.apache.maven.plugins:maven-de
dependabot[bot] commented on PR #14318:
URL: https://github.com/apache/pinot/pull/14318#issuecomment-2442699266
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
ashishjayamohan opened a new pull request, #14322:
URL: https://github.com/apache/pinot/pull/14322
- Adds sleep time to `SparkSegmentMetadataPushIntegrationTest.java` to allow
integration tests to run locally (previously, had error with Helix state
transition due to premature call to `build
Jackie-Jiang merged PR #14317:
URL: https://github.com/apache/pinot/pull/14317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.19.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 8bf9649476 Bump com.puppycrawl.tools:checkstyle from 10.18.2 to 10.1
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.google.errorprone-error_prone_annotations-2.35.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was b546a1ff72 Bump com.google.errorprone:error_prone_annot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3891a783ae Bump com.google.errorprone:error_prone_annotations from
2.34.0 to 2.35.1 (#14316)
add d5bcd780ac Bump
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3891a783ae Bump com.google.errorprone:error_prone
Jackie-Jiang merged PR #14316:
URL: https://github.com/apache/pinot/pull/14316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
dependabot[bot] opened a new pull request, #14321:
URL: https://github.com/apache/pinot/pull/14321
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0.
Commits
https://github.com/indutny/elliptic/commit/b8a7edd61a0d9bddd0bbf3436a4b476401edbe20";>b8a7edd
6.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/pinot-controller/src/main/resources/elliptic-6.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at b6d6955d87 Bump elliptic in /pinot-controller/
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.42
in repository https://gitbox.apache.org/repos/asf/pinot.git
was bb553fbdbd Bump com.nimbusds:nimbus-jose-jwt from 9.41.2 to 9.42
The revi
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 0f984e81d3 enforce continue on error flag during batch segment
ingestion as well (#14309)
add 08b5e87c47 Bump com
Jackie-Jiang merged PR #14315:
URL: https://github.com/apache/pinot/pull/14315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #14311:
URL: https://github.com/apache/pinot/pull/14311#issuecomment-2442470400
I don't fully follow the change. When `LineIterator` is used, it can still
throw exception on `hasNext()`. What is the main difference between these 2
approaches?
--
This is an au
bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1819522670
##
pinot-perf/src/main/java/org/apache/pinot/perf/LazyDataList.java:
##
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1819522670
##
pinot-perf/src/main/java/org/apache/pinot/perf/LazyDataList.java:
##
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
vrajat commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1819408284
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java:
##
@@ -0,0 +1,190 @@
+/**
+ * Licensed to the Apache Software Foundation
bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1819303257
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/DateTimeTransformerFactory.java:
##
@@ -29,23 +30,39 @@ private DateTimeTr
yashmayya commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818944382
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##
@@ -326,6 +326,31 @@ public void testAggregateServerR
yashmayya commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818981343
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java:
##
@@ -78,12 +86,78 @@ private List processRo
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 8e1a74d2a2 Add Tabled Is Disabled Error (#14199)
add 0f984e81d3 enforce continue on error flag during batch s
KKcorps merged PR #14309:
URL: https://github.com/apache/pinot/pull/14309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
dependabot[bot] opened a new pull request, #14320:
URL: https://github.com/apache/pinot/pull/14320
Bumps
[org.apache.maven.plugins:maven-jxr-plugin](https://github.com/apache/maven-jxr)
from 3.5.0 to 3.6.0.
Commits
https://github.com/apache/maven-jxr/commit/9e1d08ad2f33bffc23c
gortiz commented on issue #14196:
URL: https://github.com/apache/pinot/issues/14196#issuecomment-2441367082
BTW, in the document I also mention
https://github.com/apache/hive/pull/5249, which tries to apply the same in Hive
--
This is an automated message from the Apache Git Service.
To r
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-dependency-plugin-3.8.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at d26d6df9d4 Bump org.apache.maven.plugins:maven-de
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.github.luben-zstd-jni-1.5.6-7
in repository https://gitbox.apache.org/repos/asf/pinot.git
at c9fbd38d71 Bump com.github.luben:zstd-jni from 1.5.6-6 to 1.5.6-7
No
dependabot[bot] opened a new pull request, #14318:
URL: https://github.com/apache/pinot/pull/14318
Bumps
[org.apache.maven.plugins:maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin)
from 3.7.1 to 3.8.1.
Release notes
Sourced from https://github.com/apache/
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at f4bcf8b577 Bump org.apache.maven.plugins:maven-jxr-plugi
dependabot[bot] opened a new pull request, #14319:
URL: https://github.com/apache/pinot/pull/14319
Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from
1.5.6-6 to 1.5.6-7.
Commits
See full diff in https://github.com/luben/zstd-jni/commits";>compare view
gortiz commented on issue #14196:
URL: https://github.com/apache/pinot/issues/14196#issuecomment-2441363664
I've seen several cases where this feature would help in Pinot queries
written by our customers. Remember that this is not limited to WITH expressions
(but common expressions in the r
dependabot[bot] opened a new pull request, #14317:
URL: https://github.com/apache/pinot/pull/14317
Bumps
[com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle)
from 10.18.2 to 10.19.0.
Release notes
Sourced from https://github.com/checkstyle/checkstyle/release
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.19.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 8bf9649476 Bump com.puppycrawl.tools:checkstyle from 10.18.2 to
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.google.errorprone-error_prone_annotations-2.35.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at b546a1ff72 Bump com.google.errorprone:error_prone_a
dependabot[bot] opened a new pull request, #14316:
URL: https://github.com/apache/pinot/pull/14316
Bumps
[com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone)
from 2.34.0 to 2.35.1.
Release notes
Sourced from https://github.com/google/error-prone/r
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.42
in repository https://gitbox.apache.org/repos/asf/pinot.git
at bb553fbdbd Bump com.nimbusds:nimbus-jose-jwt from 9.41.2 to 9.42
No n
dependabot[bot] opened a new pull request, #14315:
URL: https://github.com/apache/pinot/pull/14315
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.41.2 to 9.42.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/sr
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.29.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at f82e73bf67 Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.1
No n
dependabot[bot] opened a new pull request, #14314:
URL: https://github.com/apache/pinot/pull/14314
Bumps software.amazon.awssdk:bom from 2.29.0 to 2.29.1.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
|
gortiz commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1818901813
##
pinot-perf/src/main/java/org/apache/pinot/perf/LazyDataList.java:
##
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
KKcorps commented on PR #14311:
URL: https://github.com/apache/pinot/pull/14311#issuecomment-2441299598
@Jackie-Jiang 14309 won't handle the case where .hasNext() itself fails. I
understand this is backward incompatible. I think the main thing we want to do
is use lineIterator by default in
gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818880977
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java:
##
@@ -113,12 +187,115 @@ private List processRa
gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818835138
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/serde/RexExpressionToProtoExpression.java:
##
@@ -64,9 +64,15 @@ public static Expressions.FunctionCa
gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818856485
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java:
##
@@ -78,12 +86,78 @@ private List processRowsW
gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818819771
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##
@@ -326,6 +326,31 @@ public void testAggregateServerRetu
gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818853675
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java:
##
@@ -78,12 +86,78 @@ private List processRowsW
gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818829059
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##
@@ -326,6 +326,31 @@ public void testAggregateServerRetu
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818808387
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxSendNode.java:
##
@@ -130,4 +130,12 @@ public int hashCode() {
return Objects.ha
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818806333
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxReceiveNode.java:
##
@@ -108,6 +108,11 @@ public PlanNode withInputs(List inputs) {
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818689731
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/EquivalentStagesFinder.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Fo
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818764279
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ParentToChildrenCalculator.java:
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818762986
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ParentToChildrenCalculator.java:
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818760763
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ParentToChildrenCalculator.java:
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818757493
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/GroupedStages.java:
##
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software Foundation
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818740275
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/GroupedStages.java:
##
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software Foundation
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818697673
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/EquivalentStagesFinder.java:
##
@@ -0,0 +1,339 @@
+/**
+ * Licensed to the Apache Software Fo
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818737302
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/GroupedStages.java:
##
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software Foundation
gortiz commented on code in PR #14296:
URL: https://github.com/apache/pinot/pull/14296#discussion_r1818733174
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/GroupedStages.java:
##
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software Foundation
96 matches
Mail list logo