praveenc7 commented on code in PR #14001:
URL: https://github.com/apache/pinot/pull/14001#discussion_r1819929776
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DefaultGroupByExecutor.java:
##########
@@ -127,6 +139,48 @@ public DefaultGroupByExecutor(QueryContext queryContext,
AggregationFunction[] a
}
}
+ private Map<ExpressionContext, Integer>
getGroupByExpressionSizesFromPredicates(QueryContext queryContext) {
+ FilterContext filterContext = queryContext.getFilter();
+ if (filterContext == null || queryContext.getGroupByExpressions() == null)
{
+ return null;
+ }
+
+ Set<Predicate> predicateColumns = new HashSet<>();
+ if (filterContext.getType() == FilterContext.Type.AND) {
+ for (FilterContext child : filterContext.getChildren()) {
+ FilterContext.Type type = child.getType();
+ if (type != FilterContext.Type.PREDICATE && type !=
FilterContext.Type.AND) {
+ return null;
+ } else if (child.getPredicate() != null) {
+ predicateColumns.add(child.getPredicate());
+ }
+ }
+ } else if (filterContext.getPredicate() != null) {
+ predicateColumns.add(filterContext.getPredicate());
+ } else {
+ return null;
+ }
+
+ // Collect IN and EQ predicates and store their sizes
+ Map<ExpressionContext, Integer> predicateSizeMap =
predicateColumns.stream()
+ .filter(predicate -> predicate.getType() == Predicate.Type.IN ||
predicate.getType() == Predicate.Type.EQ)
+ .collect(Collectors.toMap(
+ Predicate::getLhs,
+ predicate -> (predicate.getType() == Predicate.Type.IN)
+ ? ((InPredicate) predicate).getValues().size()
+ : 1,
+ Integer::sum
Review Comment:
right, let me fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
