gortiz commented on code in PR #14264:
URL: https://github.com/apache/pinot/pull/14264#discussion_r1818835138
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/serde/RexExpressionToProtoExpression.java:
##########
@@ -64,9 +64,15 @@ public static Expressions.FunctionCall
convertFunctionCall(RexExpression.Functio
for (RexExpression operand : operands) {
protoOperands.add(convertExpression(operand));
}
- return
Expressions.FunctionCall.newBuilder().setDataType(convertColumnDataType(functionCall.getDataType()))
-
.setFunctionName(functionCall.getFunctionName()).addAllFunctionOperands(protoOperands)
- .setIsDistinct(functionCall.isDistinct()).build();
+ //@formatter:off
Review Comment:
nit: you shouldn't need to add this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
