ashishjayamohan commented on code in PR #14313:
URL: https://github.com/apache/pinot/pull/14313#discussion_r1819883986
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/EqualityUtils.java:
##########
@@ -156,9 +156,12 @@ public static boolean isEqualIgnoreOrder(@Nullable List
left, @Nullable List rig
public static boolean isEqualSet(@Nullable Set left, @Nullable Set right) {
if (left != null && right != null) {
- return isEqualIgnoreOrder(Arrays.asList(left.toArray()),
Arrays.asList(right.toArray()));
+ if (left.size() != right.size()) {
+ return false;
+ }
+ return left.containsAll(right) && right.containsAll(left);
Review Comment:
Sounds good. I used this format since this is what's used in `isEqualMap`,
but it is definitely redundant for sets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
