codecov-commenter commented on PR #13897:
URL: https://github.com/apache/pinot/pull/13897#issuecomment-2314317591
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya commented on code in PR #13895:
URL: https://github.com/apache/pinot/pull/13895#discussion_r1733960568
##
pinot-perf/pom.xml:
##
@@ -87,6 +87,15 @@
org.testng
testng
+
Review Comment:
The `testng` dependency was already there so not too sure
deepthi912 commented on code in PR #13789:
URL: https://github.com/apache/pinot/pull/13789#discussion_r1733939096
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -44,6 +49,7 @@
* the column indexes available.
*/
public clas
deepthi912 commented on code in PR #13296:
URL: https://github.com/apache/pinot/pull/13296#discussion_r1733938729
##
pinot-spi/src/test/java/org/apache/pinot/spi/data/SchemaInfoTest.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
deepthi912 commented on code in PR #13296:
URL: https://github.com/apache/pinot/pull/13296#discussion_r1733937490
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##
@@ -118,6 +121,26 @@ public List listSchemaNames(@Con
raghavyadav01 commented on code in PR #13897:
URL: https://github.com/apache/pinot/pull/13897#discussion_r1733928012
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##
@@ -264,39 +264,9 @@ public static ColumnMetadataImpl
yjqg commented on PR #13871:
URL: https://github.com/apache/pinot/pull/13871#issuecomment-2313910914
When the producer(s) and/or consumer(s) are deployed at the other machines,
they need to connect to the bootstrap server.
--
This is an automated message from the Apache Git Service.
T
abhioncbr commented on PR #13823:
URL: https://github.com/apache/pinot/pull/13823#issuecomment-2313905201
Sure, closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
abhioncbr closed pull request #13823: Avro version upgrade with primitive array
handling.
URL: https://github.com/apache/pinot/pull/13823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/avro.version-1.12.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was b5e54e17ce Bump avro.version from 1.11.3 to 1.12.0
The revisions that were on this b
dependabot[bot] commented on PR #13754:
URL: https://github.com/apache/pinot/pull/13754#issuecomment-2313892285
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
Jackie-Jiang closed pull request #13754: Bump avro.version from 1.11.3 to 1.12.0
URL: https://github.com/apache/pinot/pull/13754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jackie-Jiang commented on PR #13823:
URL: https://github.com/apache/pinot/pull/13823#issuecomment-2313891980
@abhioncbr Since there are 2 newly introduced major issues, let's hold a
little bit on the upgrade. Thanks again for taking the time and find all these
details!
--
This is an auto
Jackie-Jiang commented on code in PR #13863:
URL: https://github.com/apache/pinot/pull/13863#discussion_r1733735193
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -178,6 +178,17 @@ public static class ControllerPeriodicTasksConf {
p
Jackie-Jiang commented on PR #13868:
URL: https://github.com/apache/pinot/pull/13868#issuecomment-2313870332
Please address the comments before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Jackie-Jiang commented on PR #13871:
URL: https://github.com/apache/pinot/pull/13871#issuecomment-2313868720
Trying to understand the usage. Can you share more on when do you want to
specify a host other than local?
--
This is an automated message from the Apache Git Service.
To respond t
Jackie-Jiang commented on issue #13861:
URL: https://github.com/apache/pinot/issues/13861#issuecomment-2313863011
You may ask questions in our Slack `troubleshooting` channel, where you
might be able to find answer faster :)
--
This is an automated message from the Apache Git Service.
To
Jackie-Jiang commented on issue #13861:
URL: https://github.com/apache/pinot/issues/13861#issuecomment-2313858668
Yes. Retention manager should be able to remove segments from deep store
after they expire
--
This is an automated message from the Apache Git Service.
To respond to the messa
Jackie-Jiang closed issue #13861: [Question] S3 as deep storage usage is high
URL: https://github.com/apache/pinot/issues/13861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jackie-Jiang closed issue #10872: Has pinot supported subquery?
URL: https://github.com/apache/pinot/issues/10872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
Jackie-Jiang commented on issue #7043:
URL: https://github.com/apache/pinot/issues/7043#issuecomment-2313833724
This is supported with multi-stage engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Jackie-Jiang closed issue #7043: Support query result post-aggregation / nested
query
URL: https://github.com/apache/pinot/issues/7043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Jackie-Jiang commented on issue #13833:
URL: https://github.com/apache/pinot/issues/13833#issuecomment-2313791037
Have you configured inverted index on `Origin` column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Jackie-Jiang commented on code in PR #13789:
URL: https://github.com/apache/pinot/pull/13789#discussion_r1733660624
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##
@@ -239,6 +239,11 @@ public String forTableReload(String tableNa
Jackie-Jiang commented on code in PR #13296:
URL: https://github.com/apache/pinot/pull/13296#discussion_r1733654738
##
pinot-spi/src/test/java/org/apache/pinot/spi/data/SchemaInfoTest.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ankitsultana commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733631826
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java:
##
@@ -169,6 +170,16 @@ private static SegmentNameGenerator
getSegm
Jackie-Jiang commented on code in PR #13897:
URL: https://github.com/apache/pinot/pull/13897#discussion_r1733576186
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##
@@ -264,39 +264,9 @@ public static ColumnMetadataImpl
f
raghavyadav01 commented on PR #13897:
URL: https://github.com/apache/pinot/pull/13897#issuecomment-2313651607
Thanks for the feedback @Jackie-Jiang I have incorporated the review
comment and updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the m
Jackie-Jiang commented on PR #13898:
URL: https://github.com/apache/pinot/pull/13898#issuecomment-2313650018
@jayeshchoudhary Can you help take a look at this? We need to upgrade these
dependencies to fix vulnerabilities
--
This is an automated message from the Apache Git Service.
To resp
Jackie-Jiang merged PR #13892:
URL: https://github.com/apache/pinot/pull/13892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 64eb3237d7 Upgrade dependencies to fix vulnerabit
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/pinot-controller/src/main/resources/multi-746005873a
in repository https://gitbox.apache.org/repos/asf/pinot.git
at f74ac0e4e7 Bump webpack, webpack-cli and web
dependabot[bot] opened a new pull request, #13898:
URL: https://github.com/apache/pinot/pull/13898
Bumps [webpack](https://github.com/webpack/webpack),
[webpack-cli](https://github.com/webpack/webpack-cli) and
[webpack-dev-server](https://github.com/webpack/webpack-dev-server). These
depen
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7d824749d2 Remove Kafka 0.9 plugin. (#13893)
7d82
Jackie-Jiang merged PR #13893:
URL: https://github.com/apache/pinot/pull/13893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.27.13
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 2501c2169a Bump software.amazon.awssdk:bom from 2.27.12 to 2.27.13
The r
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from d8ca448779 [Hotfix] init correct upsert manager with
_enableDeletedKeysCompactionConsistency config (#13896)
add
Jackie-Jiang merged PR #13894:
URL: https://github.com/apache/pinot/pull/13894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang closed pull request #13829: Revert Hadoop back to 3.3.6
URL: https://github.com/apache/pinot/pull/13829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
Jackie-Jiang commented on PR #13897:
URL: https://github.com/apache/pinot/pull/13897#issuecomment-2313552021
Good catch! As discussed offline, changing load time only to treat min/max
separately should be good enough. We don't want to use max length in field spec
because user might set a hu
Jackie-Jiang commented on code in PR #13895:
URL: https://github.com/apache/pinot/pull/13895#discussion_r1733446373
##
pinot-perf/pom.xml:
##
@@ -87,6 +87,15 @@
org.testng
testng
+
Review Comment:
Do we use testng or mockito in perf? If so, we should
lnbest0707-uber commented on code in PR #13890:
URL: https://github.com/apache/pinot/pull/13890#discussion_r1733445582
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SchemaConformingTransformerV2.java:
##
@@ -439,18 +439,29 @@ private Extra
lnbest0707-uber commented on code in PR #13890:
URL: https://github.com/apache/pinot/pull/13890#discussion_r1733441558
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SchemaConformingTransformerV2.java:
##
@@ -439,18 +439,29 @@ private Extra
real-mj-song commented on issue #13772:
URL: https://github.com/apache/pinot/issues/13772#issuecomment-2313373258
Confirmed all components (server/broker/minion/controller) start on ipv6
only & dual stack envs ✅
--
This is an automated message from the Apache Git Service.
To respond to t
real-mj-song closed issue #13772: Pinot should run on ipv6 only env without
issues
URL: https://github.com/apache/pinot/issues/13772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d8ca448779 [Hotfix] init correct upsert man
ankitsultana merged PR #13896:
URL: https://github.com/apache/pinot/pull/13896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
raghavyadav01 opened a new pull request, #13897:
URL: https://github.com/apache/pinot/pull/13897
Currently addColumnMinMaxValueInfo in SegmentColumnIndexCreator does not
honor the column field maxLength for adding min/max values in metadata. If
minString for a column is longer than default
rohityadav1993 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733370718
##
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java:
##
@@ -76,13 +84,25 @@ public PinotSinkFunc
rohityadav1993 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733370718
##
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java:
##
@@ -76,13 +84,25 @@ public PinotSinkFunc
rohityadav1993 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733348850
##
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java:
##
@@ -95,8 +100,12 @@ public class FlinkS
rohityadav1993 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733342937
##
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java:
##
@@ -119,7 +139,7 @@ public void invoke(T
rohityadav1993 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733340637
##
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfig.java:
##
@@ -52,7 +52,9 @@ public class BatchConfig {
private final boolean _exclu
codecov-commenter commented on PR #13896:
URL: https://github.com/apache/pinot/pull/13896#issuecomment-2313220439
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13896?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ankitsultana commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733264000
##
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/BatchConfig.java:
##
@@ -185,6 +189,14 @@ public boolean isExcludeSequenceId() {
return _exclu
tibrewalpratik17 opened a new pull request, #13896:
URL: https://github.com/apache/pinot/pull/13896
Introduced in #13347
When `enableDeletedKeysCompactionConsistency` is set to true, we should
initialize `ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes`
and in case o
abhioncbr commented on issue #13806:
URL: https://github.com/apache/pinot/issues/13806#issuecomment-2312742108
I assume we are adding a new module based on Kafka3 and for sometime we
support both Kafka2 and Kafka3. Is it correct understanding?
--
This is an automated message from the Apac
codecov-commenter commented on PR #13895:
URL: https://github.com/apache/pinot/pull/13895#issuecomment-2312596778
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13895?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya opened a new pull request, #13895:
URL: https://github.com/apache/pinot/pull/13895
- https://github.com/apache/pinot/pull/13832 removed the `jmh-core`
dependency (accidentally presumable) from the `pinot-perf` module leading to
the following error on attempting to run any of the J
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.27.13
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 2501c2169a Bump software.amazon.awssdk:bom from 2.27.12 to 2.27.13
N
dependabot[bot] opened a new pull request, #13894:
URL: https://github.com/apache/pinot/pull/13894
Bumps software.amazon.awssdk:bom from 2.27.12 to 2.27.13.
[