yashmayya commented on code in PR #13895:
URL: https://github.com/apache/pinot/pull/13895#discussion_r1733960568
##########
pinot-perf/pom.xml:
##########
@@ -87,6 +87,15 @@
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
</dependency>
+ <dependency>
Review Comment:
The `testng` dependency was already there so not too sure about that one and
I tried running a few benchmarks after removing it and they work fine. I can go
ahead and remove it in this PR if you'd like.
Mockito is needed for `BenchmarkQueries` and `BenchmarkOrderByQueries`
because they extend `BaseQueriesTest` which does use Mockito -
https://github.com/apache/pinot/blob/64eb3237d782a2b5dd092edae2415b8c1d12bf37/pinot-core/src/test/java/org/apache/pinot/queries/BaseQueriesTest.java#L78
I've updated the scope for `mockito-core` to `compile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
