Jackie-Jiang commented on code in PR #13895:
URL: https://github.com/apache/pinot/pull/13895#discussion_r1733446373
##########
pinot-perf/pom.xml:
##########
@@ -87,6 +87,15 @@
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
</dependency>
+ <dependency>
Review Comment:
Do we use testng or mockito in perf? If so, we should probably change them
to `compile` scope
##########
pinot-perf/pom.xml:
##########
@@ -87,6 +87,15 @@
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-core</artifactId>
Review Comment:
jmh-core is a sub-module of `jmh-generator-annprocess`. I guess we should
remove the `provided` scope from `jmh-generator-annprocess`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
