rohityadav1993 commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1733348850
##########
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java:
##########
@@ -95,8 +100,12 @@ public class FlinkSegmentWriter implements SegmentWriter {
private transient Counter _processedRecords;
private transient volatile long _lastRecordProcessingTimeMs = 0;
- public FlinkSegmentWriter(int indexOfSubtask, MetricGroup metricGroup) {
+ public FlinkSegmentWriter(int indexOfSubtask, MetricGroup metricGroup,
String segmentNamePrefix,
Review Comment:
right, PinotSinkFunction is exposed for Flink and not a whole lot of benefit
in using FlinkSegmentWriter directly.
There is a `FileBasedSegmentWriter` implementing the interface
`SegmentWriter` for general use.
Still, let me call this out in the description and mark backward
incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
