Jackie-Jiang commented on issue #13123:
URL: https://github.com/apache/pinot/issues/13123#issuecomment-2105593159
@deepthi912 `_maxLength` property is available in `FieldSpec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Jackie-Jiang merged PR #13115:
URL: https://github.com/apache/pinot/pull/13115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 0cc5d10430 upgrade flink to 1.19.0 (#12659)
add 46b41cca39 Optimize unnecessary extra array allocation and convers
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0cc5d10430 upgrade flink to 1.19.0 (#12659)
0cc5d
Jackie-Jiang merged PR #12659:
URL: https://github.com/apache/pinot/pull/12659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #13061:
URL: https://github.com/apache/pinot/issues/13061#issuecomment-2105589557
I see. So basically you want to apply TTL on any date time field, where
Pinot can automatically apply a filter?
--
This is an automated message from the Apache Git Service.
To
Jackie-Jiang commented on code in PR #13113:
URL: https://github.com/apache/pinot/pull/13113#discussion_r1597366773
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java:
##
@@ -36,7 +36,7 @@ public class Ki
Jackie-Jiang commented on code in PR #13112:
URL: https://github.com/apache/pinot/pull/13112#discussion_r1597365556
##
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/OffsetStartStatus.java:
##
@@ -0,0 +1,24 @@
+/**
+ * Lic
Jackie-Jiang merged PR #12886:
URL: https://github.com/apache/pinot/pull/12886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #12886:
URL: https://github.com/apache/pinot/pull/12886#discussion_r1597362896
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -608,172 +721,153 @@ protected SegmentDataManager unregisterSegment
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from fe8d39506b bugfix: use consumerDir during lucene realtime segment
conversion (#13094)
add b4fa06aa1c Bump com.ni
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.39
in repository https://gitbox.apache.org/repos/asf/pinot.git
was faee89aa0d Bump com.nimbusds:nimbus-jose-jwt from 9.37.3 to 9.39
The revi
Jackie-Jiang merged PR #13130:
URL: https://github.com/apache/pinot/pull/13130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fe8d39506b bugfix: use consumerDir during lucene
Jackie-Jiang merged PR #13094:
URL: https://github.com/apache/pinot/pull/13094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
deepthi912 commented on issue #13123:
URL: https://github.com/apache/pinot/issues/13123#issuecomment-2105558526
@npawar To clarify more, Should we add any config property so that user can
have the flexibility to set the maximum length or should it be like fixed
length defined inside our cod
deepthi912 commented on PR #13086:
URL: https://github.com/apache/pinot/pull/13086#issuecomment-2105548836
I noticed that registery, pipeline have static methods which are used by
some of the classes. These static methods are calling RecordEnricherFactory
which is again implemented by funct
deepthi912 commented on PR #13086:
URL: https://github.com/apache/pinot/pull/13086#issuecomment-2105538754
@Jackie-Jiang From what I observed, RecordEnricherFactory is implemented by
two types of enrichers(clp and function). Pipeline, registery has some set of
static methods calling Record
npawar closed issue #12635: `createDictionaryForColumn` does not take into
account inverted index
URL: https://github.com/apache/pinot/issues/12635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from c77a65d334 fix flakey test, avoid early finalization (#13095)
add c32a4a2654 Add a safe version of `CLStaticHttpH
mayankshriv merged PR #13124:
URL: https://github.com/apache/pinot/pull/13124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.
sar12332111 closed pull request #13132: Update
ControllerAdminApiApplication.java
URL: https://github.com/apache/pinot/pull/13132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sar12332111 commented on code in PR #13132:
URL: https://github.com/apache/pinot/pull/13132#discussion_r1597305755
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java:
##
@@ -149,4 +140,20 @@ public void filter(ContainerRequestCon
deepthi912 commented on issue #12635:
URL: https://github.com/apache/pinot/issues/12635#issuecomment-2105390906
@npawar Yes, we can close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
deepthi912 commented on PR #13086:
URL: https://github.com/apache/pinot/pull/13086#issuecomment-2105390466
Sure, I wanted to do that too. Will look and see where I can improve further
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
itschrispeck commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597297983
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
itschrispeck commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597297983
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
Jackie-Jiang commented on PR #13097:
URL: https://github.com/apache/pinot/pull/13097#issuecomment-2105371520
In the given example, the problem is actually from the recursive call of
`data = JSON_FORMAT(data)`. I don't think Pinot allows this (maybe I was wrong).
If we configure the ingest
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a2e85ebf85 Bump com.google.cloud:libraries-bom from 26.38.0 to 26.39.0
(#13129)
add c77a65d334 fix flakey test, a
Jackie-Jiang merged PR #13095:
URL: https://github.com/apache/pinot/pull/13095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #13096:
URL: https://github.com/apache/pinot/pull/13096#discussion_r1597289114
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/string/StringJoinOrderByDistinctFunction.java:
##
@@ -0,0 +1,112 @@
+/**
+ * Licensed
Jackie-Jiang commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
Jackie-Jiang commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
codecov-commenter commented on PR #13132:
URL: https://github.com/apache/pinot/pull/13132#issuecomment-2105336499
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on PR #13080:
URL: https://github.com/apache/pinot/pull/13080#issuecomment-2105322777
cc @snleee @swaminathanmanish @KKcorps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Jackie-Jiang commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1597256279
##
pinot-common/src/main/codegen/includes/parserImpls.ftl:
##
@@ -109,3 +109,14 @@ SqlNode SqlPhysicalExplain() :
nDynamicParams);
}
}
+SqlNode
rseetham commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597258100
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java:
##
@@ -48,21 +50,158 @@ public static
rseetham commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597254062
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufSchemaUtils.java:
##
@@ -0,0 +1,180 @@
+/**
+ * L
Jackie-Jiang commented on code in PR #13132:
URL: https://github.com/apache/pinot/pull/13132#discussion_r1597250043
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java:
##
@@ -149,4 +140,20 @@ public void filter(ContainerRequestCo
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.google.cloud-libraries-bom-26.39.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 78044130d8 Bump com.google.cloud:libraries-bom from 26.38.0 to 26.39.
Jackie-Jiang merged PR #13129:
URL: https://github.com/apache/pinot/pull/13129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from be18e68c5c Bump org.testcontainers:pulsar from 1.19.7 to 1.19.8
(#13118)
add a2e85ebf85 Bump com.google.cloud:lib
mayankshriv commented on PR #13124:
URL: https://github.com/apache/pinot/pull/13124#issuecomment-2105295727
> Hi, just to mention, I am working on one of the issues along with the
little refactoring around swagger-ui itself. refactoring includes the bean
creation part. If this bugfix is not
deemoliu commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597161188
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufSchemaUtils.java:
##
@@ -0,0 +1,180 @@
+/**
+ * L
deemoliu commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597159361
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java:
##
@@ -48,21 +50,158 @@ public static
xiangfu0 closed pull request #13133: Security fix for CLStaticHttpHandler
URL: https://github.com/apache/pinot/pull/13133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
deemoliu commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597155830
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java:
##
@@ -48,21 +50,158 @@ public static
xiangfu0 opened a new pull request, #13133:
URL: https://github.com/apache/pinot/pull/13133
Extend CLStaticHttpHandler to prevent the file/directory listing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
deemoliu commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597127452
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java:
##
@@ -0,0 +1,121 @@
codecov-commenter commented on PR #13131:
URL: https://github.com/apache/pinot/pull/13131#issuecomment-2105140546
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13131?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
deemoliu commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1597127452
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java:
##
@@ -0,0 +1,121 @@
sar12332111 opened a new pull request, #13132:
URL: https://github.com/apache/pinot/pull/13132
Secure static file handling to prevent path traversal attacks
- Implemented a new SafeStaticHttpHandler
- Configured the ControllerAdminApiApplication
- Modified the setupSwagger meth
abhioncbr commented on PR #13122:
URL: https://github.com/apache/pinot/pull/13122#issuecomment-2105098946
@mayankshriv, I added your [PR](https://github.com/apache/pinot/pull/13124)
changes here in this refactored code.
--
This is an automated message from the Apache Git Service.
To resp
soumitra-st opened a new pull request, #13131:
URL: https://github.com/apache/pinot/pull/13131
Added a cluster level configuration `instance.pool.and.replica.group.check`
to enable instance pool and replica group configuration check in table config.
If a Pinot cluster is configured wi
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.38
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 1eaf5e2e71 Bump com.nimbusds:nimbus-jose-jwt from 9.37.3 to 9.38
The
dependabot[bot] closed pull request #13119: Bump com.nimbusds:nimbus-jose-jwt
from 9.37.3 to 9.38
URL: https://github.com/apache/pinot/pull/13119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #13119:
URL: https://github.com/apache/pinot/pull/13119#issuecomment-2104474577
Superseded by #13130.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.39
in repository https://gitbox.apache.org/repos/asf/pinot.git
at faee89aa0d Bump com.nimbusds:nimbus-jose-jwt from 9.37.3 to 9.39
No n
dependabot[bot] opened a new pull request, #13130:
URL: https://github.com/apache/pinot/pull/13130
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.37.3 to 9.39.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/sr
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.48
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 2b77669d22 Bump aws.sdk.version from 2.25.44 to 2.25.48
The revisions that were
dependabot[bot] opened a new pull request, #13129:
URL: https://github.com/apache/pinot/pull/13129
Bumps
[com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom)
from 26.38.0 to 26.39.0.
Release notes
Sourced from https://github.com/googleapis/java-cloud-bom/
dependabot[bot] commented on PR #13120:
URL: https://github.com/apache/pinot/pull/13120#issuecomment-2104473202
Superseded by #13128.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.google.cloud-libraries-bom-26.39.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 78044130d8 Bump com.google.cloud:libraries-bom from 26.38.0 to 26
dependabot[bot] closed pull request #13120: Bump aws.sdk.version from 2.25.44
to 2.25.48
URL: https://github.com/apache/pinot/pull/13120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.49
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 02bc91d0dd Bump aws.sdk.version from 2.25.44 to 2.25.49
No new revisions were ad
dependabot[bot] opened a new pull request, #13128:
URL: https://github.com/apache/pinot/pull/13128
Bumps `aws.sdk.version` from 2.25.44 to 2.25.49.
Updates `software.amazon.awssdk:bom` from 2.25.44 to 2.25.49
Updates `software.amazon.awssdk:apache-client` from 2.25.44 to 2.25.49
abhioncbr commented on PR #13124:
URL: https://github.com/apache/pinot/pull/13124#issuecomment-2104417025
Hi, just to mention, I am working on one of the issues along with the little
refactoring around swagger-ui itself. refactoring includes the bean creation
part. If this bugfix is not urg
gortiz opened a new issue, #13127:
URL: https://github.com/apache/pinot/issues/13127
Like https://github.com/apache/pinot/issues/13126 but for EXCEPT.
In Postgres:
```
postgres=# select * from A;
1
1
2
3
4
postgres=# select * from B;
2
p
gortiz opened a new issue, #13126:
URL: https://github.com/apache/pinot/issues/13126
In SQL intersect may be modified with the all modifier. For example:
if table A contains a column a with values `[1,1,2,3,4]` and B contains a
column b with values `[1, 1, 2]`:
```
select *
spoofster123 commented on issue #13125:
URL: https://github.com/apache/pinot/issues/13125#issuecomment-2104330846
https://github.com/apache/pinot/blob/be18e68c5c10e73d1cc541d35e6d04355aac9921/pinot-controller/src/main/resources/app/utils/axios-config.ts#L83C1-L83C55
it seems to be being set
suddendust commented on issue #11211:
URL: https://github.com/apache/pinot/issues/11211#issuecomment-2104236477
>controller deep store uri to the ZK (or open a rest api), and server can
use the same uri if it is not configured
@Jackie-Jiang I am in favour of this. We shouldn't fail wh
gortiz commented on PR #13106:
URL: https://github.com/apache/pinot/pull/13106#issuecomment-2104059812
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
72 matches
Mail list logo
