deepthi912 commented on PR #13086: URL: https://github.com/apache/pinot/pull/13086#issuecomment-2105538754
@Jackie-Jiang From what I observed, RecordEnricherFactory is implemented by two types of enrichers(clp and function). Pipeline, registery has some set of static methods calling RecordEnricherFactory and other util classes utilizing them. Although RecordEnricher had similar methods as RecordTransformer, I don't see any interface in RecordTransformer serving the purpose of RecordEnricherFactory. I feel it's also ok to leave the implementation as it was previously for better structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
