Jackie-Jiang commented on code in PR #13113:
URL: https://github.com/apache/pinot/pull/13113#discussion_r1597366773
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java:
##########
@@ -36,7 +36,7 @@ public class KinesisConfig {
private static final Logger LOGGER =
LoggerFactory.getLogger(KinesisConfig.class);
public static final String STREAM_TYPE = "kinesis";
- public static final String SHARD_ITERATOR_TYPE = "shardIteratorType";
+ public static final String INIT_SHARD_ITERATOR_TYPE =
"initShardIteratorType";
Review Comment:
I guess this is backward incompatible. Should we call it out?
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java:
##########
@@ -67,7 +67,7 @@ public class KinesisConfig {
// TODO: this is a starting point, until a better default is figured out
public static final String DEFAULT_MAX_RECORDS = "20";
- public static final String DEFAULT_SHARD_ITERATOR_TYPE =
ShardIteratorType.LATEST.toString();
+ public static final String DEFAULT_INIT_SHARD_ITERATOR_TYPE =
ShardIteratorType.TRIM_HORIZON.toString();
Review Comment:
What does `TRIM_HORIZON` stand for? Is this similar to `EARLIEST`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
