Jackie-Jiang commented on code in PR #13112: URL: https://github.com/apache/pinot/pull/13112#discussion_r1597365556
########## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/OffsetStartStatus.java: ########## @@ -0,0 +1,24 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.stream.kinesis; + +public enum OffsetStartStatus { Review Comment: Basically we want to have a flag to mark the first segment of a partition. I think adding a flag in the ZK metadata is more general. Without the flag, we can treat the segment with sequence id 0 as the first segment. The reason why we still want to have a flag: - When consumption failed on segment 0, we might recreate segment 1 which is also the start of the partition - We can check if the flag exist to determine whether we are migrating from the inclusive offset to exclusive offset for existing tables ########## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisPartitionGroupOffset.java: ########## @@ -40,10 +40,20 @@ public class KinesisPartitionGroupOffset implements StreamPartitionMsgOffset { private final String _shardId; private final String _sequenceNumber; + private final OffsetStartStatus _startStatus; Review Comment: Seems it is not persistent to the offset string. Is this intentional? We need to think about how to migrate the current table to this new format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
