jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1584153044
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/utils/CsvParser.java:
##
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1584153320
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##
@@ -75,6 +82,15 @@ public TextIndexConfig(@JsonProperty("disabled") Bo
jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1584152935
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -181,6 +192,27 @@ private Mutable
jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1584153480
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##
@@ -108,10 +113,141 @@ private static List parseEntryAsStri
jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1584152494
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##
@@ -108,10 +113,141 @@ private static List parseEntryAsStri
codecov-commenter commented on PR #13030:
URL: https://github.com/apache/pinot/pull/13030#issuecomment-2084387960
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya opened a new pull request, #13030:
URL: https://github.com/apache/pinot/pull/13030
- The [URLEncoder::encode(String,
String)](https://docs.oracle.com/en%2Fjava%2Fjavase%2F11%2Fdocs%2Fapi%2F%2F/java.base/java/net/URLEncoder.html#encode(java.lang.String,java.lang.String))
and [URLDe
codecov-commenter commented on PR #13029:
URL: https://github.com/apache/pinot/pull/13029#issuecomment-2084327415
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13029?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
lnbest0707-uber commented on PR #13003:
URL: https://github.com/apache/pinot/pull/13003#issuecomment-2084323492
LGTM overall, echo Bill's style comments. Please help check, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
yashmayya opened a new pull request, #13029:
URL: https://github.com/apache/pinot/pull/13029
From the `File::walk` Javadoc:
https://github.com/apache/pinot/assets/23502577/676b2873-7c74-4bdd-9e8e-c168a1cfacee";>
--
This is an automated message from the Apache Git Service.
To res
mghildiy commented on issue #13004:
URL: https://github.com/apache/pinot/issues/13004#issuecomment-2084184217
@Jackie-Jiang , thanks for the lead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
deemoliu commented on PR #13005:
URL: https://github.com/apache/pinot/pull/13005#issuecomment-2083901849
+1 on making this configurable in the first version. And this change, it
will be easier for us to benchmark with different library.
There are some known cases re2j doesn't outperfo
This is an automated email from the ASF dual-hosted git repository.
jiaguo pushed a change to branch test_build
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 7b06b9f5c3 Issue #12367 (#12922)
The revisions that were on this branch are still contained in
other references; t
This is an automated email from the ASF dual-hosted git repository.
jiaguo pushed a change to branch test_build
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 7b06b9f5c3 Issue #12367 (#12922)
No new revisions were added by this update.
---
swaminathanmanish commented on issue #11446:
URL: https://github.com/apache/pinot/issues/11446#issuecomment-2083847471
@wahab-io - Could you try the workaround suggested here ?
https://apache-pinot.slack.com/archives/C011C9JHN7R/p1694409197833749
--
This is an automated message from t
Jackie-Jiang commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583822172
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -135,14 +160,128 @@ protected Transfera
Jackie-Jiang commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583818070
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -419,4 +550,122 @@ public void send(Bas
Jackie-Jiang commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583790911
##
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##
@@ -123,6 +127,17 @@ String toJsonString()
*/
long getMinConsumingFre
Jackie-Jiang closed issue #12367: [Flaky test] CaseTransformFunctionTest.
testCaseTransformFunctionWithIntResults()
URL: https://github.com/apache/pinot/issues/12367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7b06b9f5c3 Issue #12367 (#12922)
7b06b9f5c3 is de
Jackie-Jiang merged PR #12922:
URL: https://github.com/apache/pinot/pull/12922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #12945:
URL: https://github.com/apache/pinot/pull/12945#discussion_r1583694418
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/ForwardIndexConfig.java:
##
@@ -31,30 +31,46 @@
import org.apache.pinot.spi.config.table.Fie
Jackie-Jiang commented on issue #13004:
URL: https://github.com/apache/pinot/issues/13004#issuecomment-2083593634
@mghildiy It should be similar to how the `TIMESTAMP` data type is handled
(you may search the usage of `DataType.TIMESTAMP`). We need to design the
internal storage format (pre
codecov-commenter commented on PR #13028:
URL: https://github.com/apache/pinot/pull/13028#issuecomment-2083420302
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13028?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Bill-hbrhbr commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1583243217
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##
@@ -75,6 +82,15 @@ public TextIndexConfig(@JsonProperty("disabled") B
Jackie-Jiang commented on code in PR #13017:
URL: https://github.com/apache/pinot/pull/13017#discussion_r1583531976
##
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##
@@ -89,12 +91,13 @@ public static void setOptions(SqlNodeAndOptions
sqlN
estebanz01 commented on issue #12734:
URL: https://github.com/apache/pinot/issues/12734#issuecomment-2083374646
hi @hpvd it did solved my issue, but I don't think this issue should be
closed. Shouldn't the format field tell the engine how to render properly the
info?
--
This is an automa
Jackie-Jiang commented on code in PR #13017:
URL: https://github.com/apache/pinot/pull/13017#discussion_r1583521074
##
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##
@@ -301,6 +304,43 @@ public static Expression getLiteralExpression(Object
Jackie-Jiang commented on code in PR #13018:
URL: https://github.com/apache/pinot/pull/13018#discussion_r1583516981
##
pinot-plugins/pinot-file-system/pinot-adls/pom.xml:
##
@@ -67,12 +67,12 @@
net.java.dev.jna
jna-platform
-5.14.0
+${jn
klsince commented on code in PR #13017:
URL: https://github.com/apache/pinot/pull/13017#discussion_r1583511926
##
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##
@@ -89,12 +91,13 @@ public static void setOptions(SqlNodeAndOptions
sqlNodeAn
klsince commented on code in PR #13017:
URL: https://github.com/apache/pinot/pull/13017#discussion_r1583506074
##
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##
@@ -301,6 +304,43 @@ public static Expression getLiteralExpression(Object
obj
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.16.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 66edabcb32 Bump com.puppycrawl.tools:checkstyle from 10.15.0 to 10.1
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from bdfb34a4b8 Bump commons-codec:commons-codec from 1.16.1 to 1.17.0
(#13025)
add 14651a2fef Bump com.puppycrawl.too
Jackie-Jiang merged PR #13027:
URL: https://github.com/apache/pinot/pull/13027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.adobe.testing-s3mock-testcontainers-3.7.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 21a2d8d007 Bump com.adobe.testing:s3mock-testcontainers fr
dependabot[bot] commented on PR #13026:
URL: https://github.com/apache/pinot/pull/13026#issuecomment-2083350563
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
Jackie-Jiang commented on PR #13026:
URL: https://github.com/apache/pinot/pull/13026#issuecomment-2083350477
Doesn't work with java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jackie-Jiang closed pull request #13026: Bump
com.adobe.testing:s3mock-testcontainers from 2.12.2 to 3.7.1
URL: https://github.com/apache/pinot/pull/13026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Jackie-Jiang merged PR #13025:
URL: https://github.com/apache/pinot/pull/13025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 2a7f320593 Bump aws.sdk.version from 2.25.39 to 2.25.40 (#13022)
add e2cadfabf1 Bump com.google.errorprone:error_p
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.apache.datasketches-datasketches-java-6.0.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was d94b64cd22 Bump org.apache.datasketches:datasketches-java fr
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.google.errorprone-error_prone_annotations-2.27.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 02f77bd78c Bump com.google.errorprone:error_prone_annot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from fc967d0d15 Bump org.testng:testng from 7.10.1 to 7.10.2 (#13021)
add 2a7f320593 Bump aws.sdk.version from 2.25.39
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/aws.sdk.version-2.25.40
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 422d312661 Bump aws.sdk.version from 2.25.39 to 2.25.40
The revisions that were on t
Jackie-Jiang merged PR #13022:
URL: https://github.com/apache/pinot/pull/13022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from bbf63c7d72 Bump org.apache.datasketches:datasketches-java from 5.0.2
to 6.0.0 (#13024)
add bdfb34a4b8 Bump common
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from e2cadfabf1 Bump com.google.errorprone:error_prone_annotations from
2.26.1 to 2.27.0 (#13023)
add bbf63c7d72 Bump
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/commons-codec-commons-codec-1.17.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 62e8b8ab96 Bump commons-codec:commons-codec from 1.16.1 to 1.17.0
The re
Jackie-Jiang merged PR #13024:
URL: https://github.com/apache/pinot/pull/13024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #13023:
URL: https://github.com/apache/pinot/pull/13023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/org.testng-testng-7.10.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 1950c030b0 Bump org.testng:testng from 7.10.1 to 7.10.2
The revisions that were on
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 0be51ca955 Allow apply both environment variables and system
properties to user and table configs, Environment variabl
Jackie-Jiang merged PR #13021:
URL: https://github.com/apache/pinot/pull/13021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
gortiz commented on issue #12949:
URL: https://github.com/apache/pinot/issues/12949#issuecomment-2083019949
We are pretty blind here given we don't know in which stage the extra rows
are being generated. @RalfJL could you compile and run your case with the code
I have in https://github.com/
gortiz commented on issue #12809:
URL: https://github.com/apache/pinot/issues/12809#issuecomment-2082757464
> why cant we use reflection as discussed in para 1
[here](https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html#the-forward-compatibility-solution)?
What do
gortiz commented on PR #12704:
URL: https://github.com/apache/pinot/pull/12704#issuecomment-2082719975
> Is it possible to break this PR into smaller ones? Currently it covers too
many topics and is hard to track all the changes
I can try, but I think most of the topics are related.
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583055716
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -135,14 +160,128 @@ protected TransferableBlo
KKcorps commented on PR #13015:
URL: https://github.com/apache/pinot/pull/13015#issuecomment-2082652122
> There is no guarantee we can always detect gap with start offset and batch
first offset, especially after we introduce the exclusive start offset concept.
Seems like we still want to re
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583030085
##
pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java:
##
@@ -36,108 +39,129 @@
*/
public class MetadataBlock extends BaseDataBlock {
-
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582896361
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -135,14 +160,128 @@ protected TransferableBlo
dependabot[bot] opened a new pull request, #13027:
URL: https://github.com/apache/pinot/pull/13027
Bumps
[com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle)
from 10.15.0 to 10.16.0.
Release notes
Sourced from https://github.com/checkstyle/checkstyle/release
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.16.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 66edabcb32 Bump com.puppycrawl.tools:checkstyle from 10.15.0 to
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.adobe.testing-s3mock-testcontainers-3.7.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 21a2d8d007 Bump com.adobe.testing:s3mock-testcontainers fr
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/commons-codec-commons-codec-1.17.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 62e8b8ab96 Bump commons-codec:commons-codec from 1.16.1 to 1.17.0
No
dependabot[bot] opened a new pull request, #13025:
URL: https://github.com/apache/pinot/pull/13025
Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec)
from 1.16.1 to 1.17.0.
Changelog
Sourced from https://github.com/apache/commons-codec/blob/master/RELEASE-
dependabot[bot] opened a new pull request, #13024:
URL: https://github.com/apache/pinot/pull/13024
Bumps org.apache.datasketches:datasketches-java from 5.0.2 to 6.0.0.
[
from 2.26.1 to 2.27.0.
Release notes
Sourced from https://github.com/google/error-prone/r
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.40
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 422d312661 Bump aws.sdk.version from 2.25.39 to 2.25.40
No new revisions were ad
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/org.testng-testng-7.10.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 1950c030b0 Bump org.testng:testng from 7.10.1 to 7.10.2
No new revisions were a
dependabot[bot] opened a new pull request, #13021:
URL: https://github.com/apache/pinot/pull/13021
Bumps [org.testng:testng](https://github.com/testng-team/testng) from 7.10.1
to 7.10.2.
Release notes
Sourced from https://github.com/testng-team/testng/releases";>org.testng:testng's
aadilkhalifa commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1582877639
##
pinot-common/src/main/codegen/includes/parserImpls.ftl:
##
@@ -109,3 +109,14 @@ SqlNode SqlPhysicalExplain() :
nDynamicParams);
}
}
+SqlNode
aadilkhalifa commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1582876981
##
pinot-common/src/thrift/query.thrift:
##
@@ -32,6 +32,8 @@ struct PinotQuery {
11: optional map queryOptions;
12: optional bool explain;
13: optional m
codecov-commenter commented on PR #13020:
URL: https://github.com/apache/pinot/pull/13020#issuecomment-2082425755
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13020?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
davecromberge opened a new pull request, #13020:
URL: https://github.com/apache/pinot/pull/13020
This addresses excessive resource consumption and performance problems with
the following Apache Datasketches value aggregators:
- Theta
- CPC
- Tuple (Integer)
When merging sketc
RalfJL commented on issue #12949:
URL: https://github.com/apache/pinot/issues/12949#issuecomment-2082309994
Thanks for the query.
I can confirm that it returns the same amount of records as the query
```
select a.acctuniquesessionid, a.acctstatustype, a.ts, b.acctstatustype,
b.ts,
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582735688
##
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##
@@ -123,6 +127,17 @@ String toJsonString()
*/
long getMinConsumingFreshness
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582764851
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##
@@ -419,4 +550,122 @@ public void send(BaseResul
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582735688
##
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##
@@ -123,6 +127,17 @@ String toJsonString()
*/
long getMinConsumingFreshness
gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1582728941
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -798,7 +798,6 @@ protected BrokerResponse handleRequest(long re
83 matches
Mail list logo
