jackluo923 commented on code in PR #13003: URL: https://github.com/apache/pinot/pull/13003#discussion_r1584153044
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/utils/CsvParser.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.utils; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import javax.annotation.Nullable; + +public class CsvParser { + private CsvParser() { + // Hide utility class default constructor + } + + /** + * Parse the input csv string with customizable parsing behavior. Sometimes the individual values may contain comma + * and other white space characters. These characters are sometimes expected to be part of the actual argument. + * + * @param input string to split on comma + * @param escapeComma whether we should ignore "\," during splitting, replace it with "," after split Review Comment: Changed. ########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java: ########## @@ -61,6 +65,9 @@ public TextIndexConfig(@JsonProperty("disabled") Boolean disabled, @JsonProperty @JsonProperty("luceneUseCompoundFile") Boolean luceneUseCompoundFile, @JsonProperty("luceneMaxBufferSizeMB") Integer luceneMaxBufferSizeMB, @JsonProperty("luceneAnalyzerClass") String luceneAnalyzerClass, + @JsonProperty("luceneAnalyzerClassArgs") String luceneAnalyzerClassArgs, + @JsonProperty("luceneAnalyzerClassArgTypes") List<String> luceneAnalyzerClassArgTypes, Review Comment: Switched both to CsvParser in all places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
