Jackie-Jiang commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1583822172
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##########
@@ -135,14 +160,128 @@ protected TransferableBlock getNextBlock()
}
}
- private TransferableBlock constructMetadataBlock() {
- // All data blocks have been returned. Record the stats and return EOS.
- Map<String, String> executionStats = _executionStats;
+ private void mergeExecutionStats(@Nullable Map<String, String>
executionStats) {
if (executionStats != null) {
- OperatorStats operatorStats = _opChainStats.getOperatorStats(_context,
getOperatorId());
- operatorStats.recordExecutionStats(executionStats);
+ for (Map.Entry<String, String> entry : executionStats.entrySet()) {
+ DataTable.MetadataKey key =
DataTable.MetadataKey.getByName(entry.getKey());
+ if (key == null) {
+ LOGGER.debug("Skipping unknown execution stat: {}", entry.getKey());
+ continue;
+ }
+ switch (key) {
+ case UNKNOWN:
+ LOGGER.debug("Skipping unknown execution stat: {}",
entry.getKey());
+ break;
+ case TABLE:
Review Comment:
Can you explain how these 2 stats are used? I don't see them used in the
broker response, and seems the merge rule is overriding, meaning if we gathered
2 tables/operatorIds, the second one will override the first one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
