jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1584153320
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##########
@@ -75,6 +82,15 @@ public TextIndexConfig(@JsonProperty("disabled") Boolean
disabled, @JsonProperty
luceneMaxBufferSizeMB == null ?
LUCENE_INDEX_DEFAULT_MAX_BUFFER_SIZE_MB : luceneMaxBufferSizeMB;
_luceneAnalyzerClass = (luceneAnalyzerClass == null ||
luceneAnalyzerClass.isEmpty())
? FieldConfig.TEXT_INDEX_DEFAULT_LUCENE_ANALYZER_CLASS :
luceneAnalyzerClass;
+
+ // Note that we cannot depend on jackson's default behavior to
automatically coerce the comma delimited args to
+ // List<String>. This is because the args may contain comma and other
special characters such as space. Therefore,
+ // we use our own csv parser to parse the values directly.
+ _luceneAnalyzerClassArgs = CsvParser.parse(luceneAnalyzerClassArgs, true,
false);
+ _luceneAnalyzerClassArgTypes =
+ luceneAnalyzerClassArgTypes == null ? Collections.emptyList() :
luceneAnalyzerClassArgTypes;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
