codecov-commenter commented on PR #11868:
URL: https://github.com/apache/pinot/pull/11868#issuecomment-1778444559
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11868?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1371079962
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java:
##
@@ -0,0 +1,304 @@
+/**
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1371070042
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -286,6 +291,75 @@ public String getTablesOnTenan
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1371069731
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -286,6 +291,75 @@ public String getTablesOnTenan
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1371043521
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -286,6 +291,75 @@ public String getTablesOnTenan
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1371041721
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##
@@ -286,6 +291,75 @@ public String getTablesOnTenan
xiangfu0 commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1371012206
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixClust
xiangfu0 commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1371012206
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixClust
xiangfu0 commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1371011421
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixClust
xiangfu0 commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1371011135
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixClust
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1371000457
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java:
##
@@ -0,0 +1,304 @@
+/**
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370998295
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java:
##
@@ -0,0 +1,304 @@
+/**
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370997620
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java:
##
@@ -0,0 +1,304 @@
+/**
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370997292
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java:
##
@@ -0,0 +1,304 @@
+/**
vvivekiyer commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370844943
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java:
##
@@ -0,0 +1,304 @@
+/**
+
walterddr commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1370975975
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixClus
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch fix-protobuf-conflict
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 6e7fccea08 Resolve dependency conflict in pinot-protobuf module
The revisions that were on this branch ar
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new be74dc1429 Resolve dependency conflict in pinot-pro
jackjlli merged PR #11867:
URL: https://github.com/apache/pinot/pull/11867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
alvinzhangdd commented on PR #11800:
URL: https://github.com/apache/pinot/pull/11800#issuecomment-1778223148
@walterddr I addressed the comments, but I had a `Merge branch
'apache:master' into ...` commit, please let me know if I didn't do it
correctly and have to close this PR and start a
codecov-commenter commented on PR #11867:
URL: https://github.com/apache/pinot/pull/11867#issuecomment-1778140208
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370876469
##
pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java:
##
@@ -85,6 +85,8 @@ public static class Cluster {
public static final String UPDATE_USER
xiangfu0 commented on PR #11820:
URL: https://github.com/apache/pinot/pull/11820#issuecomment-1778132844
Many thanks @timveil !
Congrats on the very first PR in Pinot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xiangfu0 commented on code in PR #11820:
URL: https://github.com/apache/pinot/pull/11820#discussion_r1370872738
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java:
##
@@ -109,7 +109,9 @@ public CompletableFuture
execu
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2dca1411fb Correct case of `useMultistageEngine`
xiangfu0 closed issue #11819: JsonAsyncHttpPinotClientTransportFactory has
wrong case for `useMultiStageEngine` property
URL: https://github.com/apache/pinot/issues/11819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
xiangfu0 merged PR #11820:
URL: https://github.com/apache/pinot/pull/11820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370851013
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java:
##
@@ -244,20 +244,32 @@ public Map assign
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370848383
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java:
##
@@ -244,20 +244,32 @@ public Map assign
jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370844325
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/InstanceAssignmentConfig.java:
##
@@ -82,6 +82,7 @@ public InstanceReplicaGroupPartitionCon
jackjlli opened a new pull request, #11867:
URL: https://github.com/apache/pinot/pull/11867
In LinkedIn, a lower version of protobuf is needed. While there is more than
1 version of that got pulled:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.4.
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch fix-protobuf-conflict
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 6e7fccea08 Resolve dependency conflict in pinot-protobuf module
This branch includes the following new co
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch fix-protobuf-conflict
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 6e7fccea08ab2925df0c987357d340d2ad60c1e6
Author: Jialiang Li
AuthorDate: Tue Oct 24 14:33:27 2023 -0700
siddharthteotia commented on PR #11578:
URL: https://github.com/apache/pinot/pull/11578#issuecomment-1778024169
> Do you have a design doc for this? Trying to understand what we want to
achieve in this PR
Let's meet to share our context on where we are coming from and the overall
goa
Jackie-Jiang commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1777995354
It is intentionally done this way because this query rewrite does not
guarantee the same semantic. E.g. concat of `'a-'` and `'-b'` vs `'a'` and
`'--b'` will give the same resul
vvivekiyer commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370576854
##
pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java:
##
@@ -85,6 +85,8 @@ public static class Cluster {
public static final String UPDATE_USER =
Jackie-Jiang merged PR #11799:
URL: https://github.com/apache/pinot/pull/11799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from deab1a821b move pinot-segment-local test from unit test suite 1 to 2
(#11865)
add f1c36f1f97 pinot-s3: add woodst
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new deab1a821b move pinot-segment-local test from uni
Jackie-Jiang merged PR #11865:
URL: https://github.com/apache/pinot/pull/11865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
MeihanLi commented on issue #11866:
URL: https://github.com/apache/pinot/issues/11866#issuecomment-1777858183
cc @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
MeihanLi opened a new issue, #11866:
URL: https://github.com/apache/pinot/issues/11866
Non Aggregation Group By queries work in 0.11 but start to fail in 0.12. The
change is introduced [#9605](https://github.com/apache/pinot/pull/9605).
This is regression in 0.12 but it seems to be f
Jackie-Jiang commented on PR #11578:
URL: https://github.com/apache/pinot/pull/11578#issuecomment-1777824497
Do you have a design doc for this? Trying to understand what we want to
achieve in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, p
mcvsubbu commented on PR #11845:
URL: https://github.com/apache/pinot/pull/11845#issuecomment-168756
Do you mean that we can postpone this effort? Or, are you saying that this
is not needed anymore for your use case?
--
This is an automated message from the Apache Git Service.
To resp
ege-st commented on PR #11845:
URL: https://github.com/apache/pinot/pull/11845#issuecomment-119209
Not needed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
ege-st closed pull request #11845: [DRAFT: DO NOT MERGE] Segment builder use
column orientation build test
URL: https://github.com/apache/pinot/pull/11845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
ege-st commented on PR #11845:
URL: https://github.com/apache/pinot/pull/11845#issuecomment-118854
> Issue #4036 has another draft link (albeit very old)
Oh, cool, I'll take a look at this today.
--
This is an automated message from the Apache Git Service.
To respond to the mess
gortiz commented on code in PR #11824:
URL: https://github.com/apache/pinot/pull/11824#discussion_r1370445943
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##
@@ -176,6 +176,7 @@ private static void updateQueryOption
walterddr commented on code in PR #11824:
URL: https://github.com/apache/pinot/pull/11824#discussion_r1370416780
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##
@@ -176,6 +176,7 @@ private static void updateQueryOpt
walterddr commented on code in PR #11824:
URL: https://github.com/apache/pinot/pull/11824#discussion_r1370292158
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/nullvalue/NullValueIndexTypeTest.java:
##
@@ -0,0 +1,68 @@
+/**
Review Comment:
gortiz commented on PR #11824:
URL: https://github.com/apache/pinot/pull/11824#issuecomment-1777077013
@walterddr Test are failing now because when null handling is enabled at
query time, query plan changes. For example,
OfflineClusterIntegrationTest.testNonScanAggregationQueries fails in `
codecov-commenter commented on PR #11865:
URL: https://github.com/apache/pinot/pull/11865#issuecomment-1776844232
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 commented on PR #11835:
URL: https://github.com/apache/pinot/pull/11835#issuecomment-1776823254
Thanks for the contribution!
Please add a release notes section in the PR description as well!
--
This is an automated message from the Apache Git Service.
To respond to the me
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 60d34daf17 Multiple JDBC Driver fixes to support Jetbrains
Intellij/Datagrip database tooling (#11814)
add 70ac4
xiangfu0 merged PR #11835:
URL: https://github.com/apache/pinot/pull/11835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
xiangfu0 opened a new pull request, #11865:
URL: https://github.com/apache/pinot/pull/11865
Rebalance unit test time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
56 matches
Mail list logo
