xiangfu0 commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1371011135
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixCluster(int numInstances, boole
public void addFakeServerInstancesToAutoJoinHelixCluster(int numInstances,
boolean isSingleTenant, int baseAdminPort)
throws Exception {
for (int i = 0; i < numInstances; i++) {
- addFakeServerInstanceToAutoJoinHelixCluster(SERVER_INSTANCE_ID_PREFIX +
i, isSingleTenant, baseAdminPort + i);
+ addFakeServerInstanceToAutoJoinHelixCluster(SERVER_INSTANCE_ID_PREFIX +
i, isSingleTenant,
+ NetUtils.findOpenPort(baseAdminPort + i));
Review Comment:
This method finds the open port then create the fake instance, so it won't
happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
