jasperjiaguo commented on code in PR #11578:
URL: https://github.com/apache/pinot/pull/11578#discussion_r1370848383
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java:
##########
@@ -244,20 +244,32 @@ public Map<String, InstancePartitions> assignInstances(
private void assignInstancesForInstancePartitionsType(Map<String,
InstancePartitions> instancePartitionsMap,
TableConfig tableConfig, List<InstanceConfig> instanceConfigs,
InstancePartitionsType instancePartitionsType) {
String tableNameWithType = tableConfig.getTableName();
- if (TableConfigUtils.hasPreConfiguredInstancePartitions(tableConfig,
instancePartitionsType)) {
+ if (!TableConfigUtils.hasPreConfiguredInstancePartitions(tableConfig,
instancePartitionsType)) {
Review Comment:
It's inteneded. The new PRE_CONFIGURATION_INSTANCE_SELECTOR needs a
reference instance parition map (preconfigured) to work, therefore if
instancePartitionsMap is missing we cannot use
PRE_CONFIGURATION_INSTANCE_SELECTOR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
