walterddr commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1370975975
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixCluster(int numInstances, boole
public void addFakeServerInstancesToAutoJoinHelixCluster(int numInstances,
boolean isSingleTenant, int baseAdminPort)
throws Exception {
for (int i = 0; i < numInstances; i++) {
- addFakeServerInstanceToAutoJoinHelixCluster(SERVER_INSTANCE_ID_PREFIX +
i, isSingleTenant, baseAdminPort + i);
+ addFakeServerInstanceToAutoJoinHelixCluster(SERVER_INSTANCE_ID_PREFIX +
i, isSingleTenant,
+ NetUtils.findOpenPort(baseAdminPort + i));
Review Comment:
nit: if one port is unavailable netUtils.findOpenPort will increase by 1 -->
which essentially makes the next instance i conflict and then tries to increase
that as well. should we do truly randomize? what's limiting us to keep using
the base + i format?
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/GrpcBrokerClusterIntegrationTest.java:
##########
@@ -139,6 +139,7 @@ public void tearDown()
stopServer();
stopBroker();
stopController();
+ stopKafka();
Review Comment:
LOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
