[GitHub] [pinot] shenyu0127 opened a new pull request, #10959: Fix TransformBlockValSet::getNullBitmap.

2023-06-21 Thread via GitHub
shenyu0127 opened a new pull request, #10959: URL: https://github.com/apache/pinot/pull/10959 Currently the `TransformBlockValSet::getNullBitmap` has incorrect result if the underlying transform function's `getNullBitmap` is not using the default implementation in `BaseTransformFunction`.

[GitHub] [pinot] gortiz commented on issue #10945: `mvn clean install` fail on Mac with M1 chip

2023-06-21 Thread via GitHub
gortiz commented on issue #10945: URL: https://github.com/apache/pinot/issues/10945#issuecomment-1602077781 Hi @mingmxu. You have to options: 1. Use Rosetta to run maven, as explained in [Pinot doc](https://docs.pinot.apache.org/basics/getting-started/running-pinot-locally#m1-and-m2-mac-s

[GitHub] [pinot] Jackie-Jiang commented on issue #10952: [feature request] add broadcast mode to `AdaptiveServerSelector`

2023-06-21 Thread via GitHub
Jackie-Jiang commented on issue #10952: URL: https://github.com/apache/pinot/issues/10952#issuecomment-1601957658 I can see this feature useful for use cases with low resource usage but require high availability and low latency cc @vvivekiyer -- This is an automated message from t

[GitHub] [pinot] Jackie-Jiang commented on issue #10951: After segment purge, the segment start and end time in segment zk metadata may not reflect the correct values

2023-06-21 Thread via GitHub
Jackie-Jiang commented on issue #10951: URL: https://github.com/apache/pinot/issues/10951#issuecomment-1601955203 Checking the code in `SegmentPurger` and find the following note: ``` // The time column type info is not stored in the segment metadata. // Keep segment

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

2023-06-21 Thread via GitHub
Jackie-Jiang commented on code in PR #10463: URL: https://github.com/apache/pinot/pull/10463#discussion_r1237936450 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ## @@ -489,14 +489,16 @@ static void setDefaultTimeValueIfIn

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10948: Batch null check

2023-06-21 Thread via GitHub
Jackie-Jiang commented on code in PR #10948: URL: https://github.com/apache/pinot/pull/10948#discussion_r1237932213 ## pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/IngestionJobLauncher.java: ## @@ -136,23 +137,33 @@ public static void runIngestionJob(SegmentGene

[GitHub] [pinot] Jackie-Jiang merged pull request #10932: Make org.apache.pinot.client.BrokerResponse public

2023-06-21 Thread via GitHub
Jackie-Jiang merged PR #10932: URL: https://github.com/apache/pinot/pull/10932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: Make org.apache.pinot.client.BrokerResponse public (#10932)

2023-06-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2b47dd6892 Make org.apache.pinot.client.BrokerRes

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10943: [#10884][feature] add requestId for BrokerResponse in pinot-broker and java-client

2023-06-21 Thread via GitHub
Jackie-Jiang commented on code in PR #10943: URL: https://github.com/apache/pinot/pull/10943#discussion_r1237924010 ## pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java: ## @@ -557,4 +558,16 @@ public void addToExceptions(QueryProcessin

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10891: [WIP]: ensure min/max value generation in the segment metadata.

2023-06-21 Thread via GitHub
Jackie-Jiang commented on code in PR #10891: URL: https://github.com/apache/pinot/pull/10891#discussion_r1237916717 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java: ## @@ -119,65 +121,126

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10891: [WIP]: ensure min/max value generation in the segment metadata.

2023-06-21 Thread via GitHub
Jackie-Jiang commented on code in PR #10891: URL: https://github.com/apache/pinot/pull/10891#discussion_r1237916617 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java: ## @@ -119,65 +121,126

[GitHub] [pinot] Jackie-Jiang commented on issue #10934: TEXT_CONTAINS fails with NullPointerException

2023-06-21 Thread via GitHub
Jackie-Jiang commented on issue #10934: URL: https://github.com/apache/pinot/issues/10934#issuecomment-1601923319 @zhuangdaz Are you running the latest master branch or release version `0.12.1`? There should be no related changes between `0.12.0` and `0.12.1` -- This is an automated messa

[GitHub] [pinot] codecov-commenter commented on pull request #10937: New API to get tenant tags

2023-06-21 Thread via GitHub
codecov-commenter commented on PR #10937: URL: https://github.com/apache/pinot/pull/10937#issuecomment-1601859996 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr commented on a diff in pull request #10955: Update pinot client to not use Calcite extractTableNames

2023-06-21 Thread via GitHub
walterddr commented on code in PR #10955: URL: https://github.com/apache/pinot/pull/10955#discussion_r1237853380 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java: ## @@ -190,8 +192,10 @@ public Future executeAsync(@Nullable String tableNa

[GitHub] [pinot] walterddr commented on a diff in pull request #10955: Update pinot client to not use Calcite extractTableNames

2023-06-21 Thread via GitHub
walterddr commented on code in PR #10955: URL: https://github.com/apache/pinot/pull/10955#discussion_r1237852502 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java: ## @@ -190,8 +192,10 @@ public Future executeAsync(@Nullable String tableNa

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237845639 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -395,6 +402,18 @@ protected void finishOperat

[GitHub] [pinot] vvivekiyer commented on pull request #10845: [Multistage] Runtime changes for leveraging V1 Aggregation Functions

2023-06-21 Thread via GitHub
vvivekiyer commented on PR #10845: URL: https://github.com/apache/pinot/pull/10845#issuecomment-1601806576 Hey @walterddr , sorry about the late response (I was on-call last week). @somandal and I could do a code walk-through to explain our changes. Would that make the review process easie

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237809232 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -55,12 +64,17 @@ public class Concur

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237808398 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertTTLConfig.java: ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10845: [Multistage] Runtime changes for leveraging V1 Aggregation Functions

2023-06-21 Thread via GitHub
vvivekiyer commented on code in PR #10845: URL: https://github.com/apache/pinot/pull/10845#discussion_r1237805932 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PhysicalPlanVisitor.java: ## @@ -96,10 +102,88 @@ public MultiStageOperator visitMailboxSend

[GitHub] [pinot] deemoliu commented on a diff in pull request #10927: [POC] improve disk read for partial upsert handler

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10927: URL: https://github.com/apache/pinot/pull/10927#discussion_r1237805744 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -243,6 +249,42 @@ protected GenericR

[GitHub] [pinot] deemoliu commented on a diff in pull request #10927: [POC] improve disk read for partial upsert handler

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10927: URL: https://github.com/apache/pinot/pull/10927#discussion_r1237805324 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -219,6 +221,10 @@ protected void doA

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10845: [Multistage] Runtime changes for leveraging V1 Aggregation Functions

2023-06-21 Thread via GitHub
vvivekiyer commented on code in PR #10845: URL: https://github.com/apache/pinot/pull/10845#discussion_r1237801796 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/IdentifierContext.java: ## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] codecov-commenter commented on pull request #10958: [multistage][feature] add pipeline breaker stats collector

2023-06-21 Thread via GitHub
codecov-commenter commented on PR #10958: URL: https://github.com/apache/pinot/pull/10958#issuecomment-1601773866 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10958?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237776033 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -395,6 +402,18 @@ protected void finishOperat

[GitHub] [pinot] shenyu0127 commented on pull request #10914: Fix the NULL ordering in object single column distinct executors.

2023-06-21 Thread via GitHub
shenyu0127 commented on PR #10914: URL: https://github.com/apache/pinot/pull/10914#issuecomment-1601752054 > > Should we consider doing the same trick as primitive data types by tracking a `_hasNull` flag to avoid the extra null handling? That way the behavior is consistent across all data

[GitHub] [pinot] codecov-commenter commented on pull request #10957: [multistage][bugfix] fix pipeline breaker error block populate

2023-06-21 Thread via GitHub
codecov-commenter commented on PR #10957: URL: https://github.com/apache/pinot/pull/10957#issuecomment-1601745350 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr opened a new pull request, #10958: [multistage][feature] add pipeline breaker stats collector

2023-06-21 Thread via GitHub
walterddr opened a new pull request, #10958: URL: https://github.com/apache/pinot/pull/10958 Previously pipeline breaker stats were missing from the final broker results. this PR adds it back. depends on #10957 -- This is an automated message from the Apache Git Service. To respon

[GitHub] [pinot] walterddr opened a new pull request, #10957: [multistage][bugfix] fix pipeline breaker error block populate

2023-06-21 Thread via GitHub
walterddr opened a new pull request, #10957: URL: https://github.com/apache/pinot/pull/10957 error block doesn't populate the message back to broker. this PR fixes it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10905: Startree index build enhancement

2023-06-21 Thread via GitHub
Jackie-Jiang commented on code in PR #10905: URL: https://github.com/apache/pinot/pull/10905#discussion_r1237648011 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java: ## @@ -61,8 +62,10 @@ public class MultipleTrees

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237430802 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -395,6 +402,18 @@ protected void finishOperat

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237428186 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -181,6 +210,29 @@ protected void rem

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237426407 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -243,6 +295,47 @@ protected GenericR

[GitHub] [pinot] deemoliu commented on a diff in pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

2023-06-21 Thread via GitHub
deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237416775 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertTTLConfig.java: ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] sajjad-moradi merged pull request #10946: Add a new SegmentPurger interface method to get record purger based on table configs and schema

2023-06-21 Thread via GitHub
sajjad-moradi merged PR #10946: URL: https://github.com/apache/pinot/pull/10946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[pinot] branch master updated: Add a new SegmentPurger interface method to get record purger based on table configs and schema (#10946)

2023-06-21 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 30b5da9626 Add a new SegmentPurger interface meth

[GitHub] [pinot] klsince commented on a diff in pull request #10953: Add a PrioritizedFilterOperator

2023-06-21 Thread via GitHub
klsince commented on code in PR #10953: URL: https://github.com/apache/pinot/pull/10953#discussion_r1237353497 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/PrioritizedFilterOperator.java: ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] [pinot] snleee merged pull request #10954: Null check before closing reader

2023-06-21 Thread via GitHub
snleee merged PR #10954: URL: https://github.com/apache/pinot/pull/10954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[pinot] branch master updated: Null check before closing reader (#10954)

2023-06-21 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 70020005b1 Null check before closing reader (#1095

[pinot] branch master updated: FUNNEL_COUNT Aggregation Function (#10867)

2023-06-21 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 17ee2024dd FUNNEL_COUNT Aggregation Function (#

[GitHub] [pinot] chenboat merged pull request #10867: FUNNEL_COUNT Aggregation Function

2023-06-21 Thread via GitHub
chenboat merged PR #10867: URL: https://github.com/apache/pinot/pull/10867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] dang-stripe opened a new issue, #10956: Segments in Deleted_Segments do not get retentioned

2023-06-21 Thread via GitHub
dang-stripe opened a new issue, #10956: URL: https://github.com/apache/pinot/issues/10956 We've noticed segments in S3 are not getting deleted from the Deleted_Segments directory. This seems to be because when SegmentDeletionManager calls S3PinotFS.listFiles, it only returns files and not

[GitHub] [pinot] mayankshriv commented on issue #10921: Improve Syntax Error Messages

2023-06-21 Thread via GitHub
mayankshriv commented on issue #10921: URL: https://github.com/apache/pinot/issues/10921#issuecomment-1601157028 @abhioncbr thanks, I have assigned this to you now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pinot] walterddr commented on a diff in pull request #10873: Use pinot-query-planner utils to extract table names in pinot-controller

2023-06-21 Thread via GitHub
walterddr commented on code in PR #10873: URL: https://github.com/apache/pinot/pull/10873#discussion_r1237214589 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -185,8 +190,10 @@ private String getMultiStageQueryResponse

[pinot] branch master updated: Push out-of-order events metrics for full upsert (#10944)

2023-06-21 Thread atri
This is an automated email from the ASF dual-hosted git repository. atri pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b699cdbf81 Push out-of-order events metrics for ful

[GitHub] [pinot] atris merged pull request #10944: Push out-of-order events metrics for full upsert

2023-06-21 Thread via GitHub
atris merged PR #10944: URL: https://github.com/apache/pinot/pull/10944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10873: Use pinot-query-planner utils to extract table names in pinot-controller

2023-06-21 Thread via GitHub
tibrewalpratik17 commented on code in PR #10873: URL: https://github.com/apache/pinot/pull/10873#discussion_r1237089197 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -185,8 +190,10 @@ private String getMultiStageQueryR

[GitHub] [pinot] codecov-commenter commented on pull request #10955: Update pinot client to not use Calcite extractTableNames

2023-06-21 Thread via GitHub
codecov-commenter commented on PR #10955: URL: https://github.com/apache/pinot/pull/10955#issuecomment-1600927203 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10955?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] tibrewalpratik17 opened a new pull request, #10955: Update pinot client to not use Calcite extractTableNames

2023-06-21 Thread via GitHub
tibrewalpratik17 opened a new pull request, #10955: URL: https://github.com/apache/pinot/pull/10955 As discussed in #10873 , removing pinot-client using `extractTableNamesFromNode` which got introduced in #10692. Now in case of multistage queries, it will randomly select a broker.

[GitHub] [pinot] swaminathanmanish opened a new pull request, #10954: Null check before closing reader

2023-06-21 Thread via GitHub
swaminathanmanish opened a new pull request, #10954: URL: https://github.com/apache/pinot/pull/10954 Bubble up the exception, and not fail due to NPE, when reader does not get initialized for some reason (eg: out of memory..) -- This is an automated message from the Apache Git Service. To

[GitHub] [pinot] shounakmk219 commented on a diff in pull request #10905: Startree index build enhancement

2023-06-21 Thread via GitHub
shounakmk219 commented on code in PR #10905: URL: https://github.com/apache/pinot/pull/10905#discussion_r1236968638 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java: ## @@ -115,13 +117,33 @@ public MultipleTreesBui

[GitHub] [pinot] shounakmk219 commented on a diff in pull request #10905: Startree index build enhancement

2023-06-21 Thread via GitHub
shounakmk219 commented on code in PR #10905: URL: https://github.com/apache/pinot/pull/10905#discussion_r1236967919 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -243,10 +243,8 @@ private void processStar

[GitHub] [pinot] shounakmk219 commented on a diff in pull request #10905: Startree index build enhancement

2023-06-21 Thread via GitHub
shounakmk219 commented on code in PR #10905: URL: https://github.com/apache/pinot/pull/10905#discussion_r1236965567 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -243,10 +243,8 @@ private void processStar

[GitHub] [pinot] Aravind-Suresh commented on a diff in pull request #10897: Fixes SQL wildcard escaping in LIKE queries

2023-06-21 Thread via GitHub
Aravind-Suresh commented on code in PR #10897: URL: https://github.com/apache/pinot/pull/10897#discussion_r1236882803 ## pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java: ## @@ -64,24 +72,56 @@ public static String likeToRegexpLike(String

[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10944: Push out-of-order events metrics for full upsert

2023-06-21 Thread via GitHub
tibrewalpratik17 commented on code in PR #10944: URL: https://github.com/apache/pinot/pull/10944#discussion_r1236848951 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -375,9 +375,9 @@ protected void handl

[GitHub] [pinot] Aravind-Suresh commented on a diff in pull request #10897: Fixes SQL wildcard escaping in LIKE queries

2023-06-21 Thread via GitHub
Aravind-Suresh commented on code in PR #10897: URL: https://github.com/apache/pinot/pull/10897#discussion_r1236803233 ## pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java: ## @@ -64,24 +72,56 @@ public static String likeToRegexpLike(String

[GitHub] [pinot] Aravind-Suresh commented on a diff in pull request #10897: Fixes SQL wildcard escaping in LIKE queries

2023-06-21 Thread via GitHub
Aravind-Suresh commented on code in PR #10897: URL: https://github.com/apache/pinot/pull/10897#discussion_r1236801239 ## pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java: ## @@ -64,24 +71,42 @@ public static String likeToRegexpLike(String

[GitHub] [pinot] Aravind-Suresh commented on a diff in pull request #10897: Fixes SQL wildcard escaping in LIKE queries

2023-06-21 Thread via GitHub
Aravind-Suresh commented on code in PR #10897: URL: https://github.com/apache/pinot/pull/10897#discussion_r1236800873 ## pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java: ## @@ -64,24 +72,56 @@ public static String likeToRegexpLike(String

[GitHub] [pinot] atris commented on a diff in pull request #10944: Push out-of-order events metrics for full upsert

2023-06-21 Thread via GitHub
atris commented on code in PR #10944: URL: https://github.com/apache/pinot/pull/10944#discussion_r1236635851 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -375,9 +375,9 @@ protected void handleOutOfOrder

[GitHub] [pinot] codecov-commenter commented on pull request #10953: Add a PrioritizedFilterOperator

2023-06-21 Thread via GitHub
codecov-commenter commented on PR #10953: URL: https://github.com/apache/pinot/pull/10953#issuecomment-1600434419 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] gortiz opened a new pull request, #10953: Add a PrioritizedFilterOperator

2023-06-21 Thread via GitHub
gortiz opened a new pull request, #10953: URL: https://github.com/apache/pinot/pull/10953 This interface is used when FilterOperatorUtils tries to sort a bunch of operators. This is needed by new operators that are not included in the compilation unit. This improves FilterOperatorUti

[GitHub] [pinot] mingmxu opened a new issue, #10952: [feature request] add broadcast mode to `AdaptiveServerSelector`

2023-06-21 Thread via GitHub
mingmxu opened a new issue, #10952: URL: https://github.com/apache/pinot/issues/10952 # what's the problem? When one server instance is lost abruptly for reasons, query failures are observed for short period in two scenarios: * The running queries would fail after timeout; * Some qu

[GitHub] [pinot] atris commented on a diff in pull request #10897: Fixes SQL wildcard escaping in LIKE queries

2023-06-21 Thread via GitHub
atris commented on code in PR #10897: URL: https://github.com/apache/pinot/pull/10897#discussion_r1236485819 ## pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java: ## @@ -64,24 +72,56 @@ public static String likeToRegexpLike(String likePatt