deemoliu commented on code in PR #10915: URL: https://github.com/apache/pinot/pull/10915#discussion_r1237808398
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertTTLConfig.java: ########## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyDescription; +import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; + + +/** + * The {@code UpsertTTLConfig} class contains the upsert TTL (time-to-live) related configurations. + * Pinot upsert keeps track of all primary keys in heap, it's costly and also affects performance when table is large. + * + * If primary keys in the table have lifecycle, they won't get updated after a certain period time, then we can use the + * following configuration to enable upsert ttl feature. Pinot will only keeps track of alive primary keys in heap. + */ +@JsonIgnoreProperties(ignoreUnknown = true) +public class UpsertTTLConfig { Review Comment: @Jackie-Jiang that's a good point. i have a `getTtlInMs()` in the function, do you mean i should add a variable _ttlInMs and then get rid of the following ``` private TimeUnit _ttlTimeUnit; private long _ttlTimeValue; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
