atris commented on code in PR #10944:
URL: https://github.com/apache/pinot/pull/10944#discussion_r1236635851
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -375,9 +375,9 @@ protected void handleOutOfOrderEvent(Object
currentComparisonValue, Object recor
_numOutOfOrderEvents++;
long currentTimeNs = System.nanoTime();
if (currentTimeNs - _lastOutOfOrderEventReportTimeNs >
OUT_OF_ORDER_EVENT_MIN_REPORT_INTERVAL_NS) {
- _logger.warn("Skipped {} out-of-order events for partial-upsert table
(the last event has current comparison "
- + "value: {}, record comparison value: {})",
_numOutOfOrderEvents, currentComparisonValue,
- recordComparisonValue);
+ _logger.warn("Skipped {} out-of-order events for upsert table {} (the
last event has current comparison "
+ + "value: {}, record comparison value: {})",
_numOutOfOrderEvents, _tableNameWithType,
Review Comment:
Should we still distinguish between partial and full upserts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
