deemoliu commented on code in PR #10915:
URL: https://github.com/apache/pinot/pull/10915#discussion_r1237845639
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -395,6 +402,18 @@ protected void finishOperation() {
}
}
+ /**
+ * When TTL is enabled for upsert, this function is used to remove expired
keys from the primary key indexes.
+ */
+ @Override
+ public void removeExpiredPrimaryKeys(Comparable watermark) {
Review Comment:
@Jackie-Jiang good point. if i keep the interface
`removeExpiredPrimaryKeys(Comparable watermark)` i need to call it within the
metadata manager to access largestSeenComparisonValue - ttl.
Or i can call it in LLRealtimeDataManager with interface
`removeExpiredPrimaryKeys()` since LLRealtimeDataManager do not have access
of `largestSeenComparisonValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
