[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190655200 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/PlanFragmentMetadata.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] KKcorps commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

KKcorps commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1190648093 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -159,7 +159,11 @@ public void deleteValidDoc

[GitHub] [pinot] kishoreg commented on issue #10205: [multistage] [debuggability] Return meaningful error msg for unsupported type

kishoreg commented on issue #10205: URL: https://github.com/apache/pinot/issues/10205#issuecomment-1543278577 We should support it.. and use String for json On Wed, May 10, 2023 at 7:55 PM Abhishek Sharma ***@***.***> wrote: > I am taking up this issue. thanks > > —

[GitHub] [pinot] abhioncbr commented on issue #10205: [multistage] [debuggability] Return meaningful error msg for unsupported type

abhioncbr commented on issue #10205: URL: https://github.com/apache/pinot/issues/10205#issuecomment-1543256954 I am taking up this issue. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pinot] xiangfu0 merged pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 merged PR #10748: URL: https://github.com/apache/pinot/pull/10748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] walterddr opened a new issue, #10755: [multistage] proposal for a new executor scheduling model

walterddr opened a new issue, #10755: URL: https://github.com/apache/pinot/issues/10755 Hi All, we were discussing the threading model of the current V2 engine execution runtime and we observed several issues Issues === 1. under high QPS environment we have many thread conte

[pinot] branch master updated: Return 503 for all interrupted queries. Refactor the query killing code. (#10683)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3a8c578020 Return 503 for all interrupted que

[GitHub] [pinot] siddharthteotia merged pull request #10683: Return 503 for all interrupted queries. Refactor the query killing code.

siddharthteotia merged PR #10683: URL: https://github.com/apache/pinot/pull/10683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190449311 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/PlanFragmentMetadata.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] codecov-commenter commented on pull request #10754: Keep last completed segments for retention

codecov-commenter commented on PR #10754: URL: https://github.com/apache/pinot/pull/10754#issuecomment-1542872441 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [pinot] jtao15 closed pull request #10754: Keep last completed segments for retention

jtao15 closed pull request #10754: Keep last completed segments for retention URL: https://github.com/apache/pinot/pull/10754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] jtao15 opened a new pull request, #10754: Keep last completed segments for retention

jtao15 opened a new pull request, #10754: URL: https://github.com/apache/pinot/pull/10754 Do not delete last completed segments in retention manager such that there's no issue to create new consuming segments (e.g. the table is paused). -- This is an automated message from the Apache

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190393649 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/SubPlanMetadata.java: ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190390158 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/PlanFragmentMetadata.java: ## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190350083 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/DispatchablePlanFragment.java: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Founda

[GitHub] [pinot] walterddr commented on a diff in pull request #10683: Return 503 for all interrupted queries. Refactor the query killing code.

walterddr commented on code in PR #10683: URL: https://github.com/apache/pinot/pull/10683#discussion_r1190345922 ## pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java: ## @@ -54,7 +54,7 @@ public static void setMaxLinesOfStackTrace(int maxLinesOfSt

[pinot] branch master updated (1763e70f79 -> 738e607106)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1763e70f79 Minor Realtime Segment Commit Upload Improvements (#10725) add 738e607106 Make the TimeUnit in the DATET

[GitHub] [pinot] walterddr merged pull request #10750: Make the TimeUnit in the DATETRUNC function case insensitive.

walterddr merged PR #10750: URL: https://github.com/apache/pinot/pull/10750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190344319 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -155,9 +157,12 @@ public QueryPlannerResult planQuery(String sqlQuery, SqlNod

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190343118 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/ExchangeNode.java: ## @@ -46,11 +47,14 @@ public class ExchangeNode extends AbstractPlanNo

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190307480 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/DispatchablePlanFragment.java: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Founda

[GitHub] [pinot] sylph-eu commented on pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on PR #10746: URL: https://github.com/apache/pinot/pull/10746#issuecomment-1542681707 Could anyone trigger unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pinot] chenboat merged pull request #10725: Minor Realtime Segment Commit Upload Improvements

chenboat merged PR #10725: URL: https://github.com/apache/pinot/pull/10725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated: Minor Realtime Segment Commit Upload Improvements (#10725)

This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1763e70f79 Minor Realtime Segment Commit Upload

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #10683: Return 503 for all interrupted queries. Refactor the query killing code.

jasperjiaguo commented on code in PR #10683: URL: https://github.com/apache/pinot/pull/10683#discussion_r1190134455 ## pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java: ## @@ -54,7 +54,7 @@ public static void setMaxLinesOfStackTrace(int maxLinesO

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190225347 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/ExchangeNode.java: ## @@ -46,11 +47,14 @@ public class ExchangeNode extends AbstractPlanN

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190224594 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/PinotDispatchPlanner.java: ## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software F

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190223598 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/DispatchablePlanVisitor.java: ## @@ -41,52 +40,13 @@ public class DispatchablePlanVisitor

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r119029 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RelToStageConverter.java: ## @@ -18,8 +18,11 @@ */ package org.apache.pinot.query.plann

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190220674 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PinotLogicalQueryPlanner.java: ## @@ -0,0 +1,161 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190219754 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PinotLogicalQueryPlanner.java: ## @@ -0,0 +1,161 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190194915 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -175,7 +175,7 @@ private BrokerResponse handleRequest(

[GitHub] [pinot] deemoliu commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

deemoliu commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1190181375 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -159,7 +159,11 @@ public void deleteValidDo

[GitHub] [pinot] walterddr commented on a diff in pull request #10748: [multistage] Refactor query planner and dispatcher

walterddr commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190194491 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -175,7 +175,7 @@ private BrokerResponse handleRequest(

[GitHub] [pinot] walterddr commented on a diff in pull request #10723: 10689: Update for pinot helm release version 0.2.7

walterddr commented on code in PR #10723: URL: https://github.com/apache/pinot/pull/10723#discussion_r1190193650 ## kubernetes/helm/index.yaml: ## @@ -1,6 +1,34 @@ apiVersion: v1 entries: pinot: + - apiVersion: v1 +appVersion: 0.2.7 +created: "2023-05-04T20:38:46.9

[GitHub] [pinot] deemoliu commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

deemoliu commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1190181375 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -159,7 +159,11 @@ public void deleteValidDo

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #10683: Return 503 for all interrupted queries. Refactor the query killing code.

jasperjiaguo commented on code in PR #10683: URL: https://github.com/apache/pinot/pull/10683#discussion_r1190134455 ## pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java: ## @@ -54,7 +54,7 @@ public static void setMaxLinesOfStackTrace(int maxLinesO

[pinot] branch master updated (4f5030530f -> cb0ffc0307)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4f5030530f Add request id to the V2 broker response (#10706) add cb0ffc0307 Fix githubEvents table for quicks

[GitHub] [pinot] saurabhd336 merged pull request #10716: Fix githubEvents table for quickstart recipes

saurabhd336 merged PR #10716: URL: https://github.com/apache/pinot/pull/10716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[GitHub] [pinot] abhioncbr commented on issue #10736: [multistage] Error with Self Join

abhioncbr commented on issue #10736: URL: https://github.com/apache/pinot/issues/10736#issuecomment-1542249726 We can close this issue. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] codecov-commenter commented on pull request #10748: [WIP] refactor query planning phase

codecov-commenter commented on PR #10748: URL: https://github.com/apache/pinot/pull/10748#issuecomment-1541585370 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10748?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [pinot] jvenant commented on a diff in pull request #10731: set reader spec config and add test

jvenant commented on code in PR #10731: URL: https://github.com/apache/pinot/pull/10731#discussion_r1189460970 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskGenerator

[GitHub] [pinot] jvenant commented on a diff in pull request #10731: set reader spec config and add test

jvenant commented on code in PR #10731: URL: https://github.com/apache/pinot/pull/10731#discussion_r1189460774 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskExecutor.