xiangfu0 commented on code in PR #10748: URL: https://github.com/apache/pinot/pull/10748#discussion_r1190393649
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/SubPlanMetadata.java: ########## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import org.apache.calcite.util.Pair; + + +public class SubPlanMetadata { + + /** + * The set of tables that are scanned in this subplan. + */ + private final Set<String> _tableNames; + + /** + * The list of fields that are surfaced by this subplan. Only valid for SubPlan Id 0. + */ + private List<Pair<Integer, String>> _fields; + + private final Map<String, String> _customProperties; + + public SubPlanMetadata(Set<String> tableNames, List<Pair<Integer, String>> fields) { + _tableNames = tableNames; + _fields = fields; + _customProperties = new HashMap<>(); + } + + public List<Pair<Integer, String>> getFields() { + return _fields; + } Review Comment: Removed the customProperties from PlanFragmentMetadata and SubPlanMetadata as the info inside are not used for proto serde. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org